[TASK] Use native type declarations for $lineNumber (#1134)

Part of #811

Co-authored-by: JakeQZ <jake.github@qzdesign.co.uk>

Author: oliverklee

CHANGELOG.md

@@ -32,7 +32,7 @@ Please also have a look at our
 - Make all non-private properties `@internal` (#886)
 - Use more native type declarations and strict mode
   (#641, #772, #774, #778, #804, #841, #873, #875, #891, #922, #923, #933, #958,
-  #964, #967, #1000, #1044)
+  #964, #967, #1000, #1044, #1134)
 - Add visibility to all class/interface constants (#469)
 
 ### Deprecated

src/CSSList/CSSList.php

@@ -57,7 +57,7 @@ abstract class CSSList implements Renderable, Commentable
     /**
      * @param int<0, max> $lineNumber
      */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         $this->lineNumber = $lineNumber;
     }

src/Parser.php

@@ -20,9 +20,9 @@ class Parser
 
     /**
      * @param string $text the complete CSS as text (i.e., usually the contents of a CSS file)
-     * @param int<0, max> $lineNumber the line number (starting from 1, not from 0)
+     * @param int<1, max> $lineNumber the line number (starting from 1, not from 0)
      */
-    public function __construct($text, ?Settings $parserSettings = null, $lineNumber = 1)
+    public function __construct($text, ?Settings $parserSettings = null, int $lineNumber = 1)
     {
         if ($parserSettings === null) {
             $parserSettings = Settings::create();

src/Parsing/ParserState.php

@@ -45,15 +45,15 @@ class ParserState
     private $charset;
 
     /**
-     * @var int
+     * @var int<1, max> $lineNumber
      */
     private $lineNumber;
 
     /**
      * @param string $text the complete CSS as text (i.e., usually the contents of a CSS file)
-     * @param int<0, max> $lineNumber
+     * @param int<1, max> $lineNumber
      */
-    public function __construct($text, Settings $parserSettings, $lineNumber = 1)
+    public function __construct($text, Settings $parserSettings, int $lineNumber = 1)
     {
         $this->parserSettings = $parserSettings;
         $this->text = $text;
@@ -73,7 +73,7 @@ public function setCharset(string $charset): void
     }
 
     /**
-     * @return int
+     * @return int<1, max>
      */
     public function currentLine()
     {

src/Property/CSSNamespace.php

@@ -23,7 +23,7 @@ class CSSNamespace implements AtRule
     private $prefix;
 
     /**
-     * @var int
+     * @var int<0, max> $lineNumber
      */
     private $lineNumber;
 
@@ -39,7 +39,7 @@ class CSSNamespace implements AtRule
      * @param string|null $prefix
      * @param int<0, max> $lineNumber
      */
-    public function __construct($url, $prefix = null, $lineNumber = 0)
+    public function __construct($url, $prefix = null, int $lineNumber = 0)
     {
         $this->url = $url;
         $this->prefix = $prefix;

src/Property/Charset.php

@@ -40,7 +40,7 @@ class Charset implements AtRule
     /**
      * @param int<0, max> $lineNumber
      */
-    public function __construct(CSSString $charset, $lineNumber = 0)
+    public function __construct(CSSString $charset, int $lineNumber = 0)
     {
         $this->charset = $charset;
         $this->lineNumber = $lineNumber;

src/Property/Import.php

@@ -41,7 +41,7 @@ class Import implements AtRule
      * @param string $mediaQuery
      * @param int<0, max> $lineNumber
      */
-    public function __construct(URL $location, $mediaQuery, $lineNumber = 0)
+    public function __construct(URL $location, $mediaQuery, int $lineNumber = 0)
     {
         $this->location = $location;
         $this->mediaQuery = $mediaQuery;

src/Rule/Rule.php

@@ -37,7 +37,7 @@ class Rule implements Renderable, Commentable
     private $isImportant = false;
 
     /**
-     * @var int
+     * @var int<0, max> $lineNumber
      */
     protected $lineNumber;
 
@@ -60,7 +60,7 @@ class Rule implements Renderable, Commentable
      * @param int<0, max> $lineNumber
      * @param int $columnNumber
      */
-    public function __construct($rule, $lineNumber = 0, $columnNumber = 0)
+    public function __construct($rule, int $lineNumber = 0, $columnNumber = 0)
     {
         $this->rule = $rule;
         $this->lineNumber = $lineNumber;
@@ -143,10 +143,10 @@ public function getColNo()
     }
 
     /**
-     * @param int $lineNumber
+     * @param int<0, max> $lineNumber
      * @param int $columnNumber
      */
-    public function setPosition($lineNumber, $columnNumber): void
+    public function setPosition(int $lineNumber, $columnNumber): void
     {
         $this->columnNumber = $columnNumber;
         $this->lineNumber = $lineNumber;

src/RuleSet/AtRuleSet.php

@@ -30,7 +30,7 @@ class AtRuleSet extends RuleSet implements AtRule
      * @param string $arguments
      * @param int<0, max> $lineNumber
      */
-    public function __construct($type, $arguments = '', $lineNumber = 0)
+    public function __construct($type, $arguments = '', int $lineNumber = 0)
     {
         parent::__construct($lineNumber);
         $this->type = $type;

src/RuleSet/RuleSet.php

@@ -49,7 +49,7 @@ abstract class RuleSet implements Renderable, Commentable
     /**
      * @param int<0, max> $lineNumber
      */
-    public function __construct($lineNumber = 0)
+    public function __construct(int $lineNumber = 0)
     {
         $this->lineNumber = $lineNumber;
     }