Skip to content

Commit 60271c3

Browse files
authored
[TASK] Test more valid selectors in SelectorTest (#1473)
Also improve some of the data provider descriptions, and reorder the datasets more logically.
1 parent 1911017 commit 60271c3

1 file changed

Lines changed: 12 additions & 5 deletions

File tree

tests/Unit/Property/SelectorTest.php

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,23 @@ public function setSelectorOverwritesSelectorProvidedToConstructor(): void
5353
public static function provideSelectorsAndSpecificities(): array
5454
{
5555
return [
56-
'element' => ['a', 1],
57-
'element and descendant with pseudo-selector' => ['ol li::before', 3],
56+
'type' => ['a', 1],
5857
'class' => ['.highlighted', 10],
59-
'element with class' => ['li.green', 11],
60-
'class with pseudo-selector' => ['.help:hover', 20],
58+
'type with class' => ['li.green', 11],
59+
'pseudo-class' => [':hover', 10],
60+
'type with pseudo-class' => ['a:hover', 11],
61+
'class with pseudo-class' => ['.help:hover', 20],
6162
'ID' => ['#file', 100],
62-
'ID and descendant class' => ['#test .help', 110],
63+
'ID and descendent class' => ['#test .help', 110],
64+
'type with ID' => ['h2#my-mug', 101],
65+
'pseudo-element' => ['::before', 1],
66+
'type with pseudo-element' => ['li::before', 2],
67+
'type and descendent type with pseudo-element' => ['ol li::before', 3],
6368
'`not`' => [':not(#your-mug)', 100],
6469
// TODO, broken: The specificity should be the highest of the `:not` arguments, not the sum.
6570
'`not` with multiple arguments' => [':not(#your-mug, .their-mug)', 110],
71+
'attribute with `"`' => ['[alt="{}()[]\\"\',"]', 10],
72+
'attribute with `\'`' => ['[alt=\'{}()[]"\\\',\']', 10],
6673
];
6774
}
6875

0 commit comments

Comments
 (0)