Skip to content

Commit 6b26fa1

Browse files
committed
Changes and enhancements suggested in review (and mistakes spotted)
1 parent 104c487 commit 6b26fa1

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

tests/Unit/Property/SelectorTest.php

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,16 @@ public static function provideInvalidSelectorsForParse(): array
120120
{
121121
return [
122122
'empty string' => [''],
123-
'whitespace only' => [" \t\n\r"],
124-
'not missing closing brace' => [':not(a'],
125-
'not missing opening brace' => [':not a)'],
123+
'space' => [' '],
124+
'tab' => ["\t"],
125+
'line feed' => ["\n"],
126+
'carriage return' => ["\r"],
127+
'a `:not` missing the closing brace' => [':not(a'],
128+
'a `:not` missing the opening brace' => [':not a)'],
126129
'attribute value missing closing single quote' => ['a[href=\'#top]'],
127130
'attribute value missing closing double quote' => ['a[href="#top]'],
131+
'attribute value with mismatched quotes, single quote opening' => ['a[href=\'#top"]'],
132+
'attribute value with mismatched quotes, double quote opening' => ['a[href="#top\']'],
128133
];
129134
}
130135

@@ -149,7 +154,7 @@ public function parseThrowsExceptionWithInvalidSelector(string $selector): void
149154
public static function provideStopCharacters(): array
150155
{
151156
return [
152-
',' => ['{'],
157+
',' => [','],
153158
'{' => ['{'],
154159
'}' => ['}'],
155160
];

0 commit comments

Comments
 (0)