Skip to content

Commit 9bcb181

Browse files
committed
Remove redundant assertion in test.
Add default case for switch statement.
1 parent 6b26fa1 commit 9bcb181

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/Property/Selector.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,12 @@ public static function parse(ParserState $parserState, array &$comments = []): s
133133
break 2;
134134
}
135135
break;
136+
default:
137+
// This will never happen unless something gets broken in `ParserState`.
138+
throw new \UnexpectedValueException(
139+
'Unexpected character \'' . $nextCharacter
140+
. '\' returned from `ParserState::peek()` in `Selector::parse()`'
141+
);
136142
}
137143
$selectorParts[] = $parserState->consume(1);
138144
}

tests/Unit/Property/SelectorTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@ public function parseExtractsCommentFromSelector(string $selector): void
226226
$result = [];
227227
Selector::parse(new ParserState($selector, Settings::create()), $result);
228228

229-
self::assertArrayHasKey(0, $result);
230229
self::assertInstanceOf(Comment::class, $result[0]);
231230
self::assertSame('comment', $result[0]->getComment());
232231
}
@@ -250,10 +249,8 @@ public function parseExtractsTwoCommentsFromSelector(): void
250249
$result = [];
251250
Selector::parse(new ParserState('/*comment1*/a/*comment2*/', Settings::create()), $result);
252251

253-
self::assertArrayHasKey(0, $result);
254252
self::assertInstanceOf(Comment::class, $result[0]);
255253
self::assertSame('comment1', $result[0]->getComment());
256-
self::assertArrayHasKey(1, $result);
257254
self::assertInstanceOf(Comment::class, $result[1]);
258255
self::assertSame('comment2', $result[1]->getComment());
259256
}

0 commit comments

Comments
 (0)