Enforce that Selector is set/constructed with non-empty list/string

Author: JakeQZ

src/Property/Selector.php

@@ -58,9 +58,9 @@ class Selector implements Renderable
         /ux';
 
     /**
-     * @var list<Component>
+     * @var non-empty-list<Component>
      */
-    private $components = [];
+    private $components;
 
     /**
      * @internal since V8.8.0
@@ -74,7 +74,7 @@ public static function isValid(string $selector): bool
     }
 
     /**
-     * @param non-empty-string|list<Component> $selector
+     * @param non-empty-string|non-empty-list<Component> $selector
      *        Providing a string is deprecated in version 9.2 and will not work from v10.0
      *
      * @throws \UnexpectedValueException if the selector is not valid

tests/Unit/Property/SelectorTest.php

@@ -200,7 +200,6 @@ public static function provideInvalidSelectorsForParse(): array
      * @test
      *
      * @dataProvider provideInvalidSelectors
-     * @dataProvider provideEmptyStringAsInvalidSelector
      * @dataProvider provideInvalidSelectorsForParse
      */
     public function parseThrowsExceptionWithInvalidSelector(string $selector): void
@@ -334,7 +333,6 @@ public function constructorThrowsExceptionWithInvalidSelector(string $selector):
      * @test
      *
      * @dataProvider provideInvalidSelectors
-     * @dataProvider provideEmptyStringAsInvalidSelector
      * @dataProvider provideInvalidSelectorsForParse
      */
     public function setSelectorThrowsExceptionWithInvalidSelector(string $selector): void
@@ -395,7 +393,7 @@ public static function provideComponentsAndArrayRepresentation(): array
      */
     public function setComponentsSetsComponentsProvided(array $components, array $expectedRepresenation): void
     {
-        $subject = new Selector([]);
+        $subject = new Selector([new CompoundSelector('p')]);
 
         $subject->setComponents($components);
 
@@ -405,26 +403,30 @@ public function setComponentsSetsComponentsProvided(array $components, array $ex
 
     /**
      * @test
+     *
+     * @param non-empty-list<Component> $components
+     *
+     * @dataProvider provideComponentsAndArrayRepresentation
      */
-    public function getComponentsReturnsEmptyArrayIfNotSet(): void
+    public function getComponentsReturnsComponentsProvidedToConstructor(array $components): void
     {
-        $subject = new Selector([]);
+        $subject = new Selector($components);
 
         $result = $subject->getComponents();
 
-        self::assertSame([], $result);
+        self::assertSame($components, $result);
     }
 
     /**
      * @test
      *
-     * @param list<Component> $components
+     * @param non-empty-list<Component> $components
      *
      * @dataProvider provideComponentsAndArrayRepresentation
      */
     public function getComponentsReturnsComponentsSet(array $components): void
     {
-        $subject = new Selector([]);
+        $subject = new Selector([new CompoundSelector('p')]);
         $subject->setComponents($components);
 
         $result = $subject->getComponents();
@@ -541,7 +543,7 @@ public function doesNotCleanupSpacesWithinAttributeSelector(): void
      */
     public function getArrayRepresentationIncludesClassName(): void
     {
-        $subject = new Selector([]);
+        $subject = new Selector([new CompoundSelector('p')]);
 
         $result = $subject->getArrayRepresentation();