Skip to content

Commit d020f20

Browse files
committed
Split data providers to include/exclude '' as necessary
1 parent 4327ebf commit d020f20

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

tests/Unit/Property/SelectorTest.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ public static function provideInvalidSelectorsForParse(): array
200200
* @test
201201
*
202202
* @dataProvider provideInvalidSelectors
203+
* @dataProvider provideEmptyStringAsInvalidSelector
203204
* @dataProvider provideInvalidSelectorsForParse
204205
*/
205206
public function parseThrowsExceptionWithInvalidSelector(string $selector): void
@@ -324,12 +325,6 @@ public function parseExtractsTwoCommentsFromSelector(): void
324325
*/
325326
public function constructorThrowsExceptionWithInvalidSelector(string $selector): void
326327
{
327-
// An empty string is allowed to construct an empty object
328-
if ($selector === '') {
329-
self::expectNotToPerformAssertions();
330-
return;
331-
}
332-
333328
$this->expectException(UnexpectedTokenException::class);
334329

335330
new Selector($selector);
@@ -339,6 +334,7 @@ public function constructorThrowsExceptionWithInvalidSelector(string $selector):
339334
* @test
340335
*
341336
* @dataProvider provideInvalidSelectors
337+
* @dataProvider provideEmptyStringAsInvalidSelector
342338
* @dataProvider provideInvalidSelectorsForParse
343339
*/
344340
public function setSelectorThrowsExceptionWithInvalidSelector(string $selector): void

0 commit comments

Comments
 (0)