Remove 'heredoc'

[JakeQZ]

'heredoc' is a hangover from when PHP was just a simple scripting language.

Now it is a fully-fledged OO language, the syntax breaks readability in classes, etc., and should not be used (IOO).

• Replace all 'heredoc'
• Add code sniffer rule (or suchlike) to not allow it
• Add further rule to disallow multiline strings indented less than the code

[oliverklee]

I have checked the PHP_CodeSniffer and PHP-CS-Fixer rules and was unable to find any rules for this. Maybe we need to write a small Composer script to grep for the <<< heredoc marker.

[JakeQZ]

I have checked the PHP_CodeSniffer and PHP-CS-Fixer rules and was unable to find any rules for this. Maybe we need to write a small Composer script to grep for the <<< heredoc marker.

I found HeredocSniff in the current codebase. Looks like it would do the job. Doesn't seem to be documented, though I've established that the rule is Squiz.PHP.Heredoc, and it works. And that we don't have any remaining heredoc (or nowdoc) to replace.

Would be nice to also have a rule to disallow multiline strings that have content indented less than the code...

[JakeQZ]

I've established that the rule is Squiz.PHP.Heredoc, and it works.

#1415

[JakeQZ]

Two out of three ain't bad. There is no sniffer or fixer rule I'm aware of or can find to deal with multiline strings, and I'm not planning on writing one at this time. Thus closing, as there's nothing more that can be done here now.