Skip to content

[CLEANUP] Reformat the code with the PER-2 configuration - #1391

Merged
JakeQZ merged 1 commit into
mainfrom
cleanup/reformat
Dec 15, 2025
Merged

[CLEANUP] Reformat the code with the PER-2 configuration#1391
JakeQZ merged 1 commit into
mainfrom
cleanup/reformat

Conversation

@oliverklee

@oliverklee oliverklee commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@coveralls

coveralls commented Nov 13, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 69.027%. remained the same
when pulling 58fcc09 on cleanup/reformat
into e94cb16 on main.

@oliverklee

This comment was marked as outdated.

JakeQZ

This comment was marked as outdated.

@oliverklee
oliverklee force-pushed the cleanup/reformat branch 3 times, most recently from 6f018dc to 515488b Compare December 5, 2025 11:36
@oliverklee
oliverklee marked this pull request as ready for review December 5, 2025 11:37
@oliverklee
oliverklee requested a review from JakeQZ December 5, 2025 11:37

@JakeQZ JakeQZ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we first have some further fixes to the strings so that they are not cluttering up the view of the code (i.e. put together with concatenation if necessary).

Comment thread tests/Comment/CommentTest.php Outdated
@oliverklee

Copy link
Copy Markdown
Collaborator Author

Could we first have some further fixes to the strings so that they are not cluttering up the view of the code (i.e. put together with concatenation if necessary).

Will do.

@oliverklee
oliverklee force-pushed the cleanup/reformat branch 4 times, most recently from fef17b7 to dd1539e Compare December 14, 2025 20:06
@oliverklee
oliverklee marked this pull request as draft December 14, 2025 20:06
@oliverklee
oliverklee marked this pull request as ready for review December 15, 2025 07:29
@oliverklee
oliverklee requested a review from JakeQZ December 15, 2025 07:29
@JakeQZ
JakeQZ merged commit e58b67c into main Dec 15, 2025
23 checks passed
@JakeQZ
JakeQZ deleted the cleanup/reformat branch December 15, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants