Skip to content

[CLEANUP] Avoid multiline strings in CommentTest - #1428

Merged
JakeQZ merged 1 commit into
mainfrom
cleanup/multiline-strings
Dec 14, 2025
Merged

[CLEANUP] Avoid multiline strings in CommentTest#1428
JakeQZ merged 1 commit into
mainfrom
cleanup/multiline-strings

Conversation

@oliverklee

Copy link
Copy Markdown
Collaborator

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 69.082%. remained the same
when pulling 0b98368 on cleanup/multiline-strings
into c7fb009 on main.

@JakeQZ JakeQZ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like painstaking work - unless you have anything in your IDE to help.

These strings can't be changed, e.g. by indenting them like

$expected1 = '
    a {
        color: green;
    }
';

... (which would be more readable) because they need to be exact.

I don't believe there is a CodeSniffer or CS-Fixer rule that would do the job (the closest I found squizlabs/PHP_CodeSniffer#1557 which would change the content of the strings).

My IDE (I think) is set to convert tabs to spaces upon save (and I'm pretty sure does it blindly), so if I edited that file I'd have broken the tests.

@JakeQZ
JakeQZ merged commit f129f4c into main Dec 14, 2025
23 checks passed
@JakeQZ
JakeQZ deleted the cleanup/multiline-strings branch December 14, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants