Skip to content

[TASK] Implement RuleValueList::getArrayRepresentation() - #1457

Merged
oliverklee merged 1 commit into
mainfrom
task/array-rep/rulevaluelist
Jan 4, 2026
Merged

[TASK] Implement RuleValueList::getArrayRepresentation()#1457
oliverklee merged 1 commit into
mainfrom
task/array-rep/rulevaluelist

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

The class has no additional properties, so this is a simple case of removing the stub method so it inherits its parent implementation, and adding a test.

A stub exception-throwing method is added (pushed down the chain) to the subclass CalcRuleValueList pending implementation.

The class has no additional properties, so this is a simple case of removing
the stub method so it inherits its parent implementation, and adding a test.

A stub exception-throwing method is added (pushed down the chain) to the
subclass `CalcRuleValueList` pending implementation.
@JakeQZ
JakeQZ requested a review from oliverklee January 4, 2026 10:49
@JakeQZ JakeQZ self-assigned this Jan 4, 2026
@JakeQZ JakeQZ added testing PRs/issues adding additional tests only, or primarily testing-focused developer-specific Issues that only affect maintainers, contributors, and people submitting PRs labels Jan 4, 2026
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 70.32%. remained the same
when pulling 65be39f on task/array-rep/rulevaluelist
into 0a2c875 on main.

@oliverklee
oliverklee merged commit 09adec3 into main Jan 4, 2026
23 checks passed
@oliverklee
oliverklee deleted the task/array-rep/rulevaluelist branch January 4, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-specific Issues that only affect maintainers, contributors, and people submitting PRs testing PRs/issues adding additional tests only, or primarily testing-focused

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants