Skip to content

[TASK] Implement URL::getArrayRepresentation() - #1462

Merged
JakeQZ merged 2 commits into
mainfrom
task/array-rep-url
Jan 5, 2026
Merged

[TASK] Implement URL::getArrayRepresentation()#1462
JakeQZ merged 2 commits into
mainfrom
task/array-rep-url

Conversation

@oliverklee

@oliverklee oliverklee commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator

Part of #1440.

@oliverklee oliverklee self-assigned this Jan 5, 2026
@oliverklee oliverklee added testing PRs/issues adding additional tests only, or primarily testing-focused developer-specific Issues that only affect maintainers, contributors, and people submitting PRs labels Jan 5, 2026
@coveralls

coveralls commented Jan 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 70.514% (+0.05%) from 70.469%
when pulling a2ef9eb on task/array-rep-url
into 3c27af3 on main.

@oliverklee
oliverklee marked this pull request as draft January 5, 2026 09:45
@oliverklee
oliverklee marked this pull request as ready for review January 5, 2026 20:21
@oliverklee
oliverklee requested a review from JakeQZ January 5, 2026 20:21
JakeQZ
JakeQZ requested changes Jan 5, 2026
View reviewed changes

@JakeQZ JakeQZ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine, but there's a comment that needs fixing.

Comment thread src/Value/URL.php Outdated
@oliverklee @JakeQZ
Update src/Value/URL.php
a2ef9eb 
Co-authored-by: JakeQZ <jake.github@qzdesign.co.uk>
@oliverklee

oliverklee commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator Author

Code changes are fine, but there's a comment that needs fixing.

Thanks! It looks like I changed the sentence and then forgot to read it again.

@oliverklee
oliverklee requested a review from JakeQZ January 5, 2026 22:31
@JakeQZ
JakeQZ merged commit 2b61cd5 into main Jan 5, 2026
24 checks passed
@JakeQZ
JakeQZ deleted the task/array-rep-url branch January 5, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels

developer-specific Issues that only affect maintainers, contributors, and people submitting PRs testing PRs/issues adding additional tests only, or primarily testing-focused

Projects

None yet

Milestone

9.2.0: New features, bug fixes and de...

Development

Successfully merging this pull request may close these issues.

3 participants

@oliverklee @coveralls @JakeQZ