Skip to content

[TASK] Use Selector::parse() - #1470

Merged
oliverklee merged 1 commit into
mainfrom
refactor/selector-parse
Jan 23, 2026
Merged

[TASK] Use Selector::parse()#1470
oliverklee merged 1 commit into
mainfrom
refactor/selector-parse

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This replaces DeclarationBlock::parseSelector().

Part of #1325.

@JakeQZ JakeQZ self-assigned this Jan 22, 2026
@JakeQZ JakeQZ added the refactor For PRs that refactor code without changing functionality label Jan 22, 2026
@JakeQZ
JakeQZ marked this pull request as draft January 22, 2026 02:28
@coveralls

coveralls commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 70.738% (-0.8%) from 71.554%
when pulling cbf6bbd on refactor/selector-parse
into ae80d04 on main.

@JakeQZ
JakeQZ force-pushed the refactor/selector-parse branch from b515237 to ddff5b9 Compare January 22, 2026 18:04
@JakeQZ
JakeQZ marked this pull request as ready for review January 22, 2026 18:19
@JakeQZ
JakeQZ requested a review from oliverklee January 22, 2026 18:19
@JakeQZ

JakeQZ commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator Author

This is basically a refactoring to move the functionality from DeclarationBlock to Selector, with tests added to Selector, many of which are similar to those in DeclarationBlock.

@JakeQZ JakeQZ changed the title [TASK] Add Selector::parse [TASK] Add Selector::parse() Jan 22, 2026
@oliverklee

oliverklee commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

Is there any way to break this into smaller PRs or factor out a pre-PR to make this easier to review?

JakeQZ added a commit that referenced this pull request Jan 23, 2026
@JakeQZ
[TASK] Reorder methods in SelectorTest
56f5a0a 
Move a data provider in preparation for #1470.
@JakeQZ JakeQZ mentioned this pull request Jan 23, 2026
Merged
@JakeQZ

JakeQZ commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Is there any way to break this into smaller PRs or factor out a pre-PR to make this easier to review?

Have started with #1472 and #1473.

oliverklee pushed a commit that referenced this pull request Jan 23, 2026
@JakeQZ
[TASK] Reorder methods in SelectorTest (#1472)
1911017 
Move a data provider in preparation for #1470.
@JakeQZ
JakeQZ force-pushed the refactor/selector-parse branch 2 times, most recently from 53816f1 to 4649d14 Compare January 23, 2026 14:38
JakeQZ added a commit that referenced this pull request Jan 23, 2026
@JakeQZ
[TASK] Add Selector::parse()
104c487 
The implementation is based on `DeclarationBlock::parseSelector()`, which will
be updated to use this instead in #1470.

Part of #1325.
@JakeQZ JakeQZ changed the title [TASK] Add Selector::parse() [TASK] Use Selector::parse() Jan 23, 2026
@JakeQZ
JakeQZ force-pushed the refactor/selector-parse branch from 4649d14 to bec08b7 Compare January 23, 2026 14:44
@JakeQZ JakeQZ mentioned this pull request Jan 23, 2026
Merged
@oliverklee

oliverklee commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

Does this PR depend on #1475?

@JakeQZ

JakeQZ commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator Author

Does this PR depend on #1475?

#1475 contains part of the original commit for this PR. I'll rebase once this is merged.

@JakeQZ
JakeQZ marked this pull request as draft January 23, 2026 16:38
oliverklee pushed a commit that referenced this pull request Jan 23, 2026
@JakeQZ
[TASK] Add Selector::parse() (#1475)
ae80d04 
The implementation is based on `DeclarationBlock::parseSelector()`, which will
be updated to use this instead in #1470.

Part of #1325.
@JakeQZ
[TASK] Use Selector::parse()
cbf6bbd 
This replaces `DeclarationBlock::parseSelector()`.

Part of #1325.
@JakeQZ
JakeQZ force-pushed the refactor/selector-parse branch from bec08b7 to cbf6bbd Compare January 23, 2026 19:33
@JakeQZ
JakeQZ marked this pull request as ready for review January 23, 2026 19:35
@JakeQZ

JakeQZ commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator Author

This can be reviewed now all the pre-PRs I can think of have been merged.

oliverklee
oliverklee approved these changes Jan 23, 2026
View reviewed changes

@oliverklee oliverklee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! LGTM.

@oliverklee
oliverklee merged commit 21bb0eb into main Jan 23, 2026
24 checks passed
@oliverklee
oliverklee deleted the refactor/selector-parse branch January 23, 2026 19:57
@JakeQZ JakeQZ mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

refactor For PRs that refactor code without changing functionality

Projects

None yet

Milestone

9.2.0: New features, bug fixes and de...

Development

Successfully merging this pull request may close these issues.

3 participants

@JakeQZ @coveralls @oliverklee