Skip to content

[TASK] Test more valid selectors in SelectorTest #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 1 commit into from
Jan 23, 2026
Merged

[TASK] Test more valid selectors in SelectorTest #1473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions tests/Unit/Property/SelectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,23 @@ public function setSelectorOverwritesSelectorProvidedToConstructor(): void
public static function provideSelectorsAndSpecificities(): array
{
return [
'element' => ['a', 1],
'element and descendant with pseudo-selector' => ['ol li::before', 3],
'type' => ['a', 1],
'class' => ['.highlighted', 10],
'element with class' => ['li.green', 11],
'class with pseudo-selector' => ['.help:hover', 20],
'type with class' => ['li.green', 11],
'pseudo-class' => [':hover', 10],
'type with pseudo-class' => ['a:hover', 11],
'class with pseudo-class' => ['.help:hover', 20],
'ID' => ['#file', 100],
'ID and descendant class' => ['#test .help', 110],
'ID and descendent class' => ['#test .help', 110],
'type with ID' => ['h2#my-mug', 101],
'pseudo-element' => ['::before', 1],
'type with pseudo-element' => ['li::before', 2],
'type and descendent type with pseudo-element' => ['ol li::before', 3],
'`not`' => [':not(#your-mug)', 100],
// TODO, broken: The specificity should be the highest of the `:not` arguments, not the sum.
'`not` with multiple arguments' => [':not(#your-mug, .their-mug)', 110],
'attribute with `"`' => ['[alt="{}()[]\\"\',"]', 10],
'attribute with `\'`' => ['[alt=\'{}()[]"\\\',\']', 10],
];
}

Expand Down