[CLEANUP] Simplify tests that use getArrayRepresenation() - #1476
Merged
Conversation
We don't need to check for `arrayKeyExists` as PHPUnit will warn anyway if the code tries to access an array element that does not exist.
oliverklee
added
cleanup
testing
JakeQZ
approved these changes
Jan 23, 2026
JakeQZ
left a comment
JakeQZ
left a comment
Collaborator
There was a problem hiding this comment.
Yes, it will catch the PHP notice/warning or Error, though IIRC the test failure will be an 'error' rather than a 'failure', not that that matters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to check for
arrayKeyExistsas PHPUnit will warn anyway if the code tries to access an array element that does not exist.