Skip to content

[CLEANUP] Simplify tests that use getArrayRepresenation() #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 1 commit into from
Jan 23, 2026
Merged

[CLEANUP] Simplify tests that use getArrayRepresenation() #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/Unit/Comment/CommentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ public function getArrayRepresentationIncludesClassName(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('class', $result);
self::assertSame('Comment', $result['class']);
}

Expand All @@ -101,7 +100,6 @@ public function getArrayRepresentationIncludesContents(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('contents', $result);
self::assertSame($contents, $result['contents']);
}
}
10 changes: 7 additions & 3 deletions tests/Unit/Property/CharsetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public function getArrayRepresentationIncludesClassName(): void
{
$result = $this->subject->getArrayRepresentation();

self::assertArrayHasKey('class', $result);
self::assertSame('Charset', $result['class']);
}

Expand All @@ -53,7 +52,12 @@ public function getArrayRepresentationIncludesCharset(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('charset', $result);
self::assertSame(['class' => 'CSSString', 'contents' => $charset], $result['charset']);
self::assertSame(
[
'class' => 'CSSString',
'contents' => $charset,
],
$result['charset']
);
}
}
2 changes: 0 additions & 2 deletions tests/Unit/Value/CSSFunctionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ public function getArrayRepresentationIncludesClassName(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('class', $result);
self::assertSame('CSSFunction', $result['class']);
}

Expand All @@ -36,7 +35,6 @@ public function getArrayRepresentationIncludesFunctionName(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('name', $result);
self::assertSame('filter', $result['name']);
}
}
2 changes: 0 additions & 2 deletions tests/Unit/Value/CSSStringTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ public function getArrayRepresentationIncludesClassName(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('class', $result);
self::assertSame('CSSString', $result['class']);
}

Expand All @@ -105,7 +104,6 @@ public function getArrayRepresentationIncludesContents(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('contents', $result);
self::assertSame($contents, $result['contents']);
}

Expand Down
1 change: 0 additions & 1 deletion tests/Unit/Value/RuleValueListTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ public function getArrayRepresentationIncludesClassName(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('class', $result);
self::assertSame('RuleValueList', $result['class']);
}
}
3 changes: 0 additions & 3 deletions tests/Unit/Value/SizeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ public function getArrayRepresentationIncludesClassName(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('class', $result);
self::assertSame('Size', $result['class']);
}

Expand All @@ -121,7 +120,6 @@ public function getArrayRepresentationIncludesNumber(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('number', $result);
self::assertSame(1.0, $result['number']);
}

Expand All @@ -134,7 +132,6 @@ public function getArrayRepresentationIncludesUnit(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('unit', $result);
self::assertSame('px', $result['unit']);
}
}
10 changes: 7 additions & 3 deletions tests/Unit/Value/URLTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ public function getArrayRepresentationIncludesClassName(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('class', $result);
self::assertSame('URL', $result['class']);
}

Expand All @@ -104,7 +103,12 @@ public function getArrayRepresentationIncludesUri(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('uri', $result);
self::assertSame(['class' => 'CSSString', 'contents' => $uri], $result['uri']);
self::assertSame(
[
'class' => 'CSSString',
'contents' => $uri,
],
$result['uri']
);
}
}
21 changes: 0 additions & 21 deletions tests/Unit/Value/ValueListTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public function getArrayRepresentationIncludesClassName(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('class', $result);
self::assertSame('ConcreteValueList', $result['class']);
}

Expand All @@ -35,10 +34,6 @@ public function getArrayRepresentationIncludesStringComponent(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('components', $result);
self::assertIsArray($result['components']);
self::assertArrayHasKey(0, $result['components']);
self::assertArrayHasKey('value', $result['components'][0]);
self::assertSame('Helvetica', $result['components'][0]['value']);
}

Expand All @@ -51,10 +46,6 @@ public function getArrayRepresentationIncludesValueComponent(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('components', $result);
self::assertIsArray($result['components']);
self::assertArrayHasKey(0, $result['components']);
self::assertArrayHasKey('class', $result['components'][0]);
self::assertSame('Size', $result['components'][0]['class']);
}

Expand All @@ -67,19 +58,8 @@ public function getArrayRepresentationIncludesMultipleMixedComponents(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('components', $result);
self::assertIsArray($result['components']);

self::assertArrayHasKey(0, $result['components']);
self::assertArrayHasKey('class', $result['components'][0]);
self::assertSame('Size', $result['components'][0]['class']);

self::assertArrayHasKey(1, $result['components']);
self::assertArrayHasKey('value', $result['components'][1]);
self::assertSame('+', $result['components'][1]['value']);

self::assertArrayHasKey(2, $result['components']);
self::assertArrayHasKey('class', $result['components'][2]);
self::assertSame('Size', $result['components'][2]['class']);
}

Expand All @@ -92,7 +72,6 @@ public function getArrayRepresentationIncludesSeparator(): void

$result = $subject->getArrayRepresentation();

self::assertArrayHasKey('separator', $result);
self::assertSame(',', $result['separator']);
}
}