[TASK] Add SelectorComponent interface - #1478
Merged
Merged
Conversation
JakeQZ
added
enhancement
refactor
JakeQZ
force-pushed
the
task/selectorpart-interface
branch
from
January 23, 2026 23:21
2eb2b79 to
6562f64
Compare
Collaborator
Author
|
I'd like feedback on method names (and also interface name), as once committed it will be harder to change later. #1471 is an early example of implementation (with different names). Refs: |
oliverklee
reviewed
Jan 24, 2026
oliverklee
requested changes
Jan 27, 2026
This will be implemented by `CompoundSelector` and `Combinator` to break up the components of a selector. Part of #1325.
Change `getStringValue()` to `getValue()` (and also for `setValue()`).
JakeQZ
force-pushed
the
task/selectorpart-interface
branch
from
January 27, 2026 23:02
a293ba1 to
2eb9734
Compare
Collaborator
Author
|
GitHub won't let me reply to your review comment. I've changed the DocBlock. Is it now clearer? |
oliverklee
approved these changes
Jan 29, 2026
oliverklee
left a comment
oliverklee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, that's definitely better!
Collaborator
Author
|
As this is already in the namespace E.g. use Sabberworm\CSS\Property\Selector\SelectorComponent;Might look better as use Sabberworm\CSS\Property\Selector\Component;@oliverklee WDYT? |
Collaborator
|
@JakeQZ Totally makes sense! So I would be fine with dropping the duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be implemented by
CompoundSelectorandCombinatorto break up the components of a selector.Part of #1325.