[TASK] Extract method Selector::parseComponents - #1493
Merged
Conversation
This will allow the conversion of a selector string into an array of `Selector\Component` objects to also be used by the `setSelector()` method. Part of #1325.
JakeQZ
added
the
refactor
Collaborator
Author
|
The new private method can be moved within the class definition as a separate PR - it's where it is now to make diffing easier for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow the conversion of a selector string into an array of
Selector\Componentobjects to also be used by thesetSelector()method.Part of #1325.