Skip to content

[TASK] Render selector combinators with surrounding spaces by default - #1495

Merged
oliverklee merged 2 commits into
mainfrom
task/combinator-default-render
Feb 5, 2026
Merged

[TASK] Render selector combinators with surrounding spaces by default#1495
oliverklee merged 2 commits into
mainfrom
task/combinator-default-render

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

Part of #1325.

@JakeQZ
JakeQZ requested a review from oliverklee February 5, 2026 19:25
@JakeQZ JakeQZ self-assigned this Feb 5, 2026
@JakeQZ JakeQZ added the cleanup label Feb 5, 2026
@JakeQZ

JakeQZ commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

Eventually there will be an OutputFormat option to control this.

@coveralls

coveralls commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 72.601%. remained the same
when pulling 3fca43c on task/combinator-default-render
into 9dd05ed on main.

oliverklee
oliverklee reviewed Feb 5, 2026
View reviewed changes
Comment thread src/Property/Selector/Combinator.php Outdated
@JakeQZ @oliverklee
Make ternary operator code more readable
3fca43c 
Co-authored-by: Oliver Klee <github@oliverklee.de>
@JakeQZ
JakeQZ requested a review from oliverklee February 5, 2026 19:58
@oliverklee
oliverklee merged commit 3282587 into main Feb 5, 2026
24 checks passed
@oliverklee
oliverklee deleted the task/combinator-default-render branch February 5, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

cleanup

Projects

None yet

Milestone

9.2.0: New features, bug fixes and de...

Development

Successfully merging this pull request may close these issues.

3 participants

@JakeQZ @coveralls @oliverklee