Skip to content

[TASK] Allow construction of 'empty' Selector #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JakeQZ wants to merge 2 commits into from
Closed

[TASK] Allow construction of 'empty' Selector #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf874f7
[TASK] Allow construction of 'empty' `Selector`
JakeQZ Feb 7, 2026
2c62814
Add test for construction with empty string
JakeQZ Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Property/Selector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class Selector implements Renderable
/**
* @var string
*/
private $selector;
private $selector = '';

/**
* @internal since V8.8.0
Expand All @@ -72,9 +72,12 @@ public static function isValid(string $selector): bool
/**
* @throws \UnexpectedValueException if the selector is not valid
*/
final public function __construct(string $selector)
final public function __construct(string $selector = '')

@oliverklee oliverklee Feb 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cover creating a selector (and thus having an empty string for a selector) without passing the $selector with a test.

@JakeQZ JakeQZ Feb 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already been done, in #1498.

@oliverklee oliverklee Feb 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a test that uses new Selector() in #1498 - but I'm still at my first coffee. Am I missing something?

@JakeQZ JakeQZ Feb 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test method added was canConstructObjectWithEmptyState():

https://github.com/MyIntervals/PHP-CSS-Parser/pull/1498/changes#diff-9faf61b21720e298175bb4d7499b57e7cbf5ff21f2064fa990f2577f4a07510dR318-R327

@JakeQZ JakeQZ Feb 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added an additional test for construction without a parameter.

{
$this->setSelector($selector);
// Allow construction of empty object for content to be set later via a setter method.
if ($selector !== '') {
$this->setSelector($selector);
}
}

/**
Expand Down
12 changes: 11 additions & 1 deletion tests/Unit/Property/SelectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,17 @@ public function parseExtractsTwoCommentsFromSelector(): void
/**
* @test
*/
public function canConstructObjectWithEmptyState(): void
public function constructsObjectWithEmptyStateWithNoArgumetProvided(): void
{
$subject = new Selector();

self::assertSame('', $subject->getSelector());
}

/**
* @test
*/
public function constructsObjectWithEmptyStateWithEmptyStringProvided(): void
{
$subject = new Selector('');

Expand Down