[TASK] Use Property\Declaration in DeclarationBlockTest - #1514
Merged
Conversation
This replaces `Rule\Rule`, following #1508. Also use `getPropertyName()` rather than `getRule()` which was deprecated in This covers both the 'functional' and 'unit' flavours of the `TestCase`, and the trait that does most of the heavy lifting for the 'unit' flavour.
JakeQZ
added
testing
oliverklee
approved these changes
Feb 13, 2026
oliverklee
left a comment
oliverklee
left a comment
Collaborator
There was a problem hiding this comment.
The code looks good.
One line in the commit message got lost, though, as it probably started with #, marking it as a comment.
Collaborator
Author
Ah, it was referencing a previous PR, #1506. Will correct in the merge by including an extra word from the previous line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces
Rule\Rule, following #1508.Also use
getPropertyName()rather thangetRule()which was deprecated in #1506.This covers both the 'functional' and 'unit' flavours of the
TestCase, and the trait that does most of the heavy lifting for the 'unit' flavour.