Skip to content

[TASK] Streamline the code checker and fixer configuration #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeQZ merged 1 commit into from
Feb 17, 2026
Merged

[TASK] Streamline the code checker and fixer configuration #1535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@
"check:dynamic": [
"@check:tests"
],
"check:php:codesniffer": "phpcs --standard=config/phpcs.xml config src tests",
"check:php:fixer": "\"./.phive/php-cs-fixer\" --config=config/php-cs-fixer.php fix --dry-run -v --show-progress=dots --diff bin src tests config",
"check:php:lint": "parallel-lint src tests config bin",
"check:php:rector": "rector --no-progress-bar --dry-run --config=config/rector.php",
"check:php:codesniffer": "phpcs --standard=config/phpcs.xml bin config src tests",
"check:php:fixer": "\"./.phive/php-cs-fixer\" --config=config/php-cs-fixer.php fix --dry-run -v --show-progress=dots --diff bin config src tests",
"check:php:lint": "parallel-lint bin config src tests",
"check:php:rector": "rector process --no-progress-bar --dry-run --config=config/rector.php",

@JakeQZ JakeQZ Feb 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know why process is now needed on the command line, when it wasn't before.

I've looked at the documentation, which alludes to it with "run process command with...", but provides no links, and does not explain what the commands are, how they work, or why they might be needed.

"check:php:stan": "phpstan --no-progress --configuration=config/phpstan.neon",
"check:static": [
"@check:composer:normalize",
Expand All @@ -105,9 +105,9 @@
"@fix:php:codesniffer",
"@fix:php:fixer"
],
"fix:php:codesniffer": "phpcbf --standard=config/phpcs.xml config src tests",
"fix:php:fixer": "\"./.phive/php-cs-fixer\" --config=config/php-cs-fixer.php fix bin src tests",
"fix:php:rector": "rector --config=config/rector.php",
"fix:php:codesniffer": "phpcbf --standard=config/phpcs.xml bin config src tests",
"fix:php:fixer": "\"./.phive/php-cs-fixer\" --config=config/php-cs-fixer.php fix bin config src tests",
"fix:php:rector": "rector process --config=config/rector.php",

@JakeQZ JakeQZ Feb 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

"phpstan:baseline": "phpstan --configuration=config/phpstan.neon --generate-baseline=config/phpstan-baseline.neon --allow-empty-baseline"
},
"scripts-descriptions": {
Expand Down
4 changes: 3 additions & 1 deletion config/php-cs-fixer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

declare(strict_types=1);

return (new \PhpCsFixer\Config())
use PhpCsFixer\Config;

return (new Config())
->setRiskyAllowed(true)
->setRules(
[
Expand Down
2 changes: 2 additions & 0 deletions config/rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
return RectorConfig::configure()
->withPaths(
[
__DIR__ . '/../bin',
__DIR__ . '/../config',
__DIR__ . '/../src',
__DIR__ . '/../tests',
]
Expand Down