[TASK] Add tests for Color::getArrayRepresentation() - #1606
Merged
Conversation
oliverklee
added
testing
There was a problem hiding this comment.
Pull request overview
This PR advances the effort in #1440 to support array-based “debug/render” representations for unit tests by exercising Color::getArrayRepresentation() and enabling the inherited implementation to be used.
Changes:
- Replace the previous “not implemented” exception behavior for
Color::getArrayRepresentation()by removing the stub override, allowing inherited array representation logic to run. - Add unit tests asserting
Color::getArrayRepresentation()includes the short class name, function name, and component representations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Unit/Value/ColorTest.php | Adds assertions for Color::getArrayRepresentation() output structure (class, name, components). |
| src/Value/Color.php | Removes the exception-throwing stub so Color uses the inherited array representation implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
coverage: 72.579% (-0.03%) from 72.604% — task/array-rep/color into main |
oliverklee
force-pushed
the
task/array-rep/color
branch
from
July 26, 2026 08:35
f59ce4f to
c9a1556
Compare
JakeQZ
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1440.