upgrade symfony to 4.4|5.3

Author: digibeuk

Composer/ScriptHandler.php

@@ -17,7 +17,7 @@ class DumpEmoticonsCommandTest extends TestCase
     private $emoticonPath;
     private $emoticonFolder;
 
-    public function setUp()
+    public function setUp(): void
     {
         $this->rootDir = __DIR__.'/..';
         $this->webDir  = sys_get_temp_dir().'/symfonyFMBbcodeweb';
@@ -28,15 +28,15 @@ public function setUp()
         $this->emoticonFolder = $this->rootDir.'/../vendor/mjohnson/decoda/emoticons';
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
         if (!is_dir($this->webDir)) {
             return;
         }
         $this->removeDirectory($this->webDir);
     }
 
-    protected function removeDirectory($directory)
+    protected function removeDirectory($directory): void
     {
         $iterator = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($directory), \RecursiveIteratorIterator::CHILD_FIRST);
         foreach ($iterator as $path) {
@@ -52,7 +52,7 @@ protected function removeDirectory($directory)
         @rmdir($directory);
     }
 
-    public function testExecute()
+    public function testExecute(): void
     {
         $webDir         = $this->webDir;
         $emoticonPath   = $this->emoticonPath;

Tests/AppKernel.php

@@ -17,7 +17,7 @@ class DecodaManagerTest extends TestCase
      */
     protected $object;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $container = $this->createMock(ContainerInterface::class);
         $kernel    = $this->createMock(KernelInterface::class);
@@ -32,22 +32,22 @@ protected function setUp()
         $this->object = new DecodaManager($container, $locator, $options);
     }
 
-    public function testHas()
+    public function testHas(): void
     {
         $this->assertTrue($this->object->has(DecodaManager::DECODA_DEFAULT));
         $this->assertTrue($this->object->has('foo'));
         $this->assertFalse($this->object->has('bar'));
     }
 
-    public function testSetFilter()
+    public function testSetFilter(): void
     {
         $filter = $this->createMock(Filter::class);
         $this->object->setFilter('foo', $filter);
         $this->assertTrue($this->object->hasFilter('foo'));
         $this->assertSame($filter, $this->object->getFilter('foo'));
     }
 
-    public function testSetHook()
+    public function testSetHook(): void
     {
         $hook = $this->createMock(Hook::class);
         $this->object->setHook('foo', $hook);

Tests/Command/DumpEmoticonsCommandTest.php

@@ -7,7 +7,7 @@
 
 class DecodaTest extends TestCase
 {
-    public function testSetLocale()
+    public function testSetLocale(): void
     {
         $result = new Decoda();
         $result->setDefaultLocale('en');
@@ -23,7 +23,7 @@ public function testSetLocale()
     /**
      * @dataProvider getMessage
      */
-    public function testMessage($defaultLocale, $locale, $value, $expect)
+    public function testMessage($defaultLocale, $locale, $value, $expect): void
     {
         if ($expect instanceof \Exception) {
             $this->expectException(get_class($expect));
@@ -58,7 +58,7 @@ public function testMessage($defaultLocale, $locale, $value, $expect)
         $this->assertEquals($expect, $result->message($value));
     }
 
-    public function getMessage()
+    public function getMessage(): array
     {
         return array(
             array(null, 'en', 'foo', 'foo-en'),

Tests/Decoda/DecodaManagerTest.php

@@ -11,7 +11,7 @@
 
 class EmoticonHookTest extends TestCase
 {
-    public function testGetMatcher()
+    public function testGetMatcher(): void
     {
         $expectEmoticon = new Emoticon();
         $expectEmoticon->setSmiley(':foo:');