Fix Android cross-build with vendored OpenSSL#99
Closed
lucidium wants to merge 1 commit into
Closed
Conversation
Forward vendored OpenSSL library paths to picoquic CMake during Android cargo-ndk builds, isolate Android builds from host pkg-config state, enable minimal picoquic Android builds, and avoid Bash 4-only lowercase expansion in build_picoquic.sh for macOS Bash compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes Android
cargo-ndkcross-compilation ofslipstream-clientwith vendored OpenSSL enabled.The changes:
OPENSSL_CRYPTO_LIBRARY/OPENSSL_SSL_LIBRARYpaths to picoquic CMake when available;pkg-configpaths to avoid accidentally picking up Homebrew/macOS OpenSSL;scripts/build_picoquic.shwith portabletr, so the script works with macOS default Bash 3.2.Validation
Validated from an Android Gradle/cargo-ndk integration by building
slipstream-clientsuccessfully for:aarch64-linux-android/arm64-v8ax86_64-linux-android/x86_64armv7-linux-androideabi/armeabi-v7ai686-linux-android/x86The build keeps OpenSSL enabled for
picotls-openssl/ certificate pinning support.