[zklogin] add support for v2 vk#937
Open
joyqvq wants to merge 3 commits into
Open
Conversation
0ef7119 to
9f6b184
Compare
fc8c0a1 to
f95035a
Compare
f95035a to
a902b6e
Compare
2d62b18 to
0b69f73
Compare
6faf21e to
d109a5c
Compare
Collaborator
Author
|
@mskd12 see latest comment for caching change. the speed up for calculate_all_inputs_hash alone (on a cold cache) is 546 µs → 200µs (warm, 63% faster) overall |
06e2013 to
9594c19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculate_all_inputs_hash performance increase comes from hash_to_field for the modulus: The RSA modulus bits are packed into 248-bit field elements.
root hash = 4 Poseidon calls