sui-sdk-types, sui-rpc: add EndOfEpochTransactionKind::ForwardingAddressRegistryCreate#288
Open
lxfind wants to merge 2 commits into
Open
sui-sdk-types, sui-rpc: add EndOfEpochTransactionKind::ForwardingAddressRegistryCreate#288lxfind wants to merge 2 commits into
lxfind wants to merge 2 commits into
Conversation
…essRegistryCreate Sui is adding a ForwardingAddressRegistry system object, created by a new end-of-epoch transaction kind at protocol version 131 (MystenLabs/sui#26891). Add the variant to sui_sdk_types::EndOfEpochTransactionKind, the sui-rpc proto enum and conversions, and the vendored GraphQL schema, so the sui repo can replace its temporary todo!() conversion stubs by bumping its pinned rev.
Rust 1.97's useless_borrows_in_formatting flags the &FIELDS borrows that pbjson-build emits in serde expecting() impls (252 instances across the generated files) plus a few hand-written sites, and question_mark flags a manual if-let in FieldMaskTree. Fix the generator and regenerate, so the lint job passes again; unrelated to the new transaction kind but blocking this PR's CI.
lxfind
marked this pull request as ready for review
July 18, 2026 04:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sui is adding a
ForwardingAddressRegistrysystem object, created by a new end-of-epoch transaction kind at protocol version 131 (MystenLabs/sui#26891). That PR currently carries temporarytodo!()stubs in its proto and SDK-type conversions because this repo'sEndOfEpochTransactionKindhas no matching variant; those stubs would panic once the transaction executes on devnet, so this needs to land and be picked up via a rev bump in the sui repo before protocol 131 activates.Adds
ForwardingAddressRegistryCreate(a data-less kind, likeAddressAliasStateCreate) to:sui_sdk_types::EndOfEpochTransactionKind(appended last for BCS compatibility)sui.rpc.v2proto enum (FORWARDING_ADDRESS_REGISTRY_CREATE = 14), regenerated withmake proto, plus the proto<->sdk-type conversions