ready for WSC 3.0

Author: mutec

files/lib/system/cronjob/MysteryCodeSpiderRefreshCronjob.class.php

@@ -22,21 +22,21 @@
 class MysteryCodeSpiderRefreshCronjob implements ICronjob {
 	/**
 	 * URLs of spiderList.xml-files
-	 * @var array
+	 * @var string[]
 	 */
-	public $spiderLists = array(
+	public $spiderLists = [
 		'https://static.mysterycode.de/spiders/list.xml',
 		'https://assets.woltlab.com/spiderlist/typhoon/list.xml'
-	);
+	];
 
 	/**
 	 * list of spider-information fetched from the specified URLs
-	 * @var array
+	 * @var []
 	 */
-	public $fetchedSpiders = array();
+	public $fetchedSpiders = [];
 
 	/**
-	 * @see	\wcf\system\ICronjob::execute()
+	 * @inheritDoc
 	 */
 	public function execute(Cronjob $cronjob) {
 		$existingSpiders = SpiderCacheBuilder::getInstance()->getData();
@@ -70,11 +70,11 @@ public function execute(Cronjob $cronjob) {
 					$name = $xpath->query('ns:name', $spider)->item(0);
 					$info = $xpath->query('ns:url', $spider)->item(0);
 
-					$this->fetchedSpiders[$identifier] = array(
+					$this->fetchedSpiders[$identifier] = [
 						'spiderIdentifier' => $identifier,
 						'spiderName' => $name->nodeValue,
 						'spiderURL' => $info ? $info->nodeValue : ''
-					);
+					];
 				}
 			}
 
@@ -93,11 +93,11 @@ public function execute(Cronjob $cronjob) {
 
 			WCF::getDB()->beginTransaction();
 			foreach ($this->fetchedSpiders as $parameters) {
-				$statement->execute(array(
+				$statement->execute([
 					$parameters['spiderIdentifier'],
 					$parameters['spiderName'],
 					$parameters['spiderURL']
-				));
+				]);
 			}
 			WCF::getDB()->commitTransaction();
 		}
@@ -108,7 +108,7 @@ public function execute(Cronjob $cronjob) {
 		WCF::getDB()->beginTransaction();
 		foreach ($existingSpiders as $spider) {
 			if (!isset($this->fetchedSpiders[$spider->spiderIdentifier])) {
-				$statement->execute(array($spider->spiderIdentifier));
+				$statement->execute([$spider->spiderIdentifier]);
 			}
 		}
 		WCF::getDB()->commitTransaction();

files/lib/system/event/listener/MysteryCodeSpiderRefreshUninstallListener.class.php

@@ -8,9 +8,8 @@
 use wcf\system\WCF;
 
 class MysteryCodeSpiderRefreshUninstallListener implements IParameterizedEventListener {
-
 	/**
-	 * @see	\wcf\system\event\listener\IParameterizedEventListener::execute()
+	 * @inheritDoc
 	 */
 	public function execute($eventObj, $className, $eventName, array &$parameters) {
 		if (!empty($_POST['packageID'])) {

package.xml

@@ -6,16 +6,16 @@
 		<packagename language="de"><![CDATA[Benutzerdefinierte Spider-Liste]]></packagename>
 		<packagedescription><![CDATA[spiders]]></packagedescription>
 		<packagedescription language="de"><![CDATA[Suchmaschinenroboter]]></packagedescription>
-		<version>1.0.1</version>
-		<date>2016-08-31</date>
+		<version>1.1.0</version>
+		<date>2016-12-15</date>
 	</packageinformation>
 
 	<requiredpackages>
-		<requiredpackage minversion="2.1.0"><![CDATA[com.woltlab.wcf]]></requiredpackage>
+		<requiredpackage minversion="3.0.0 RC 1"><![CDATA[com.woltlab.wcf]]></requiredpackage>
 	</requiredpackages>
 
 	<excludedpackages>
-		<excludedpackage version="3.0.0 Alpha 1"><![CDATA[com.woltlab.wcf]]></excludedpackage>
+		<excludedpackage version="3.1.0 Alpha 1"><![CDATA[com.woltlab.wcf]]></excludedpackage>
 	</excludedpackages>
 
 	<authorinformation>
@@ -25,7 +25,7 @@
 
 	<instructions type="install">
 		<!-- files -->
-		<instruction type="file">files.tar</instruction>
+		<instruction type="file" />
 
 		<!-- XMLs -->
 		<instruction type="eventListener">xml/eventListener.xml</instruction>
@@ -35,13 +35,20 @@
 		<instruction type="script">acp/install_de.mysterycode.wcf.spiders.php</instruction>
 	</instructions>
 
-	<instructions type="update" fromversion="1.0.0 Beta 1">
+	<instructions type="update" fromversion="1.0.0">
 		<!-- files -->
-		<instruction type="file">files.tar</instruction>
+		<instruction type="file" />
+		
+		<!-- XMLs -->
+		<instruction type="eventListener">xml/eventListener.xml</instruction>
+		<instruction type="cronjob">xml/cronjob.xml</instruction>
 	</instructions>
-	
-	<instructions type="update" fromversion="1.0.0">
+	<instructions type="update" fromversion="1.0.1">
 		<!-- files -->
-		<instruction type="file">files.tar</instruction>
+		<instruction type="file" />
+		
+		<!-- XMLs -->
+		<instruction type="eventListener">xml/eventListener.xml</instruction>
+		<instruction type="cronjob">xml/cronjob.xml</instruction>
 	</instructions>
 </package>

xml/cronjob.xml

@@ -2,7 +2,7 @@
 <!DOCTYPE xml>
 <data xmlns="http://www.woltlab.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.woltlab.com https://mysterycode.de/XSD/cronjob.xsd">
 	<import>
-		<cronjob>
+		<cronjob name="de.mysterycode.wcf.spiders.refreshSpiders">
 			<classname>wcf\system\cronjob\MysteryCodeSpiderRefreshCronjob</classname>
 			<description><![CDATA[Refreshes list of search robots with custom sources (replaces WoltLabs cronjob)]]></description>
 			<description language="de"><![CDATA[Aktualisiert die Liste der Suchroboter anhand benutzerdefinierter Quellen (ersetzt WoltLabs Cronjob)]]></description>
@@ -15,4 +15,9 @@
 			<canbedisabled>1</canbedisabled>
 		</cronjob>
 	</import>
+	<delete>
+		<cronjob>
+			<classname>wcf\system\cronjob\MysteryCodeSpiderRefreshCronjob</classname>
+		</cronjob>
+	</delete>
 </data>

xml/eventListener.xml

@@ -2,7 +2,7 @@
 <!DOCTYPE xml>
 <data xmlns="http://www.woltlab.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.woltlab.com https://mysterycode.de/XSD/eventListener.xsd">
 	<import>
-		<eventlistener>
+		<eventlistener name="uninstallPackageAction">
 			<eventclassname>wcf\acp\action\UninstallPackageAction</eventclassname>
 			<eventname>execute</eventname>
 			<listenerclassname>wcf\system\event\listener\MysteryCodeSpiderRefreshUninstallListener</listenerclassname>