Move dummy VI origin beyond any known game's load address#113
Closed
Francessco121 wants to merge 1 commit into
Closed
Move dummy VI origin beyond any known game's load address#113Francessco121 wants to merge 1 commit into
Francessco121 wants to merge 1 commit into
Conversation
Contributor
Author
|
Already handled in commit df7e820 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for at least Dinosaur Planet which has a load address of
0x80000400. Currently during ubershader compilation, garbage framebuffer values will be displayed in Dino Planet since the current dummy VI overlaps the game's boot code.Tested to the best of my ability that this does not break anything in the Majora recomp.