add a stricter segment orientation check to verify connectedness

Author: memo33

src/main/scala/scripts/SegmentOrientationChecker.scala

@@ -178,13 +178,18 @@ object SegmentOrientationChecker extends Rul2Checker {
 
   private val dxdDirtroadTiles = Set(IdTile(0x5700aa00, R0F0), IdTile(0x5700aa00, R2F0))
   private val badConnectionsFalsePositives = Set.empty[Rule[IdTile]]  // currently none
+  private val standardBasicRoadFlags = Set(1,2,3,11,13)
 
   def areSegmentsBadlyConnected(tile1: Tile, tile2: Tile, rule: Rule[IdTile]): Boolean = {
     val connectingSegs1 = tile1.segs.filter(_.flags(2) != 0)
     val connectingSegs2 = tile2.segs.filter(_.flags(0) != 0)
     val commonNetworks = connectingSegs1.map(_.network).intersect(connectingSegs2.map(_.network))
     if (commonNetworks.isEmpty) {
-      connectingSegs1.nonEmpty && connectingSegs2.nonEmpty
+      connectingSegs1.nonEmpty && connectingSegs2.nonEmpty || (
+        (connectingSegs1.nonEmpty || connectingSegs2.nonEmpty)
+        && connectingSegs1.forall(s => standardBasicRoadFlags.contains(s.flags(2).abs))
+        && connectingSegs2.forall(s => standardBasicRoadFlags.contains(s.flags(0).abs))
+      )
     } else {
 
       def wellConnected(connectingSegs1: Set[Segment], connectingSegs2: Set[Segment], east: Int, west: Int): Boolean =

src/test/scala/scripts/SegmentOrientationCheckerSpec.scala

@@ -21,6 +21,7 @@ class SegmentOrientationCheckerSpec extends AnyWordSpec with Matchers {
     }
     "detect badly connected segments" in {
       SegmentOrientationChecker.areSegmentsBadlyConnected(Ave2~(11,0,2,0), Road~WS & Ard3~SE, null).shouldBe(true)
+      SegmentOrientationChecker.areSegmentsBadlyConnected(L1Road~(11,0,2,0), Road~(0,2,2,2), null).shouldBe(true)
     }
     "avoid false positives" in {
       Seq[(Tile, Tile, Rule[IdTile])](