fix TLA orientations in metarules#514
Merged
Merged
Conversation
This adds a bandaid to prevent that mirrored orientations of orth/diag TLA tiles get added to the tile orientation cache. This avoids some ambiguity between the two flavors of turning lanes (`0x5...` vs `0x7...`) in the metarule-generated RUL2 code. Additionally, this adjust the preprocessor to duplicate rules involving TLA by their upside-down variant (`R2F1`). This is necessary, as the two rules might resolve to different IDs (`0x5...` vs `0x7...`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the metarules framework to mitigate situations in which TLA networks could inadvertently end up mirrored (so turning lanes would point in the wrong direction). This used to be a major roadblock. This is achieved by explicitly overwriting the allowed orientations for specific IDs to disallow mirroring.
For this fix to become fully effective, run
sbt regenerateTileOrientationCache(which I haven't done on this branch to avoid merge conflicts).