Avenue-based OWR-4 and other NWM metarules#516
Merged
Conversation
This adds a generic mechanism `withSharedDiagonals` to automatically replace wrong-direction Avenue-like diagonal networks by appropriate shared diagonals. Also enables Owr4 90 degree curve.
…gonals` implementation This uses the existing remapping mechanism instead of adding another one. This works by locally overwriting the context. In particular, this improves error messages, as stack traces will point to the location where a rule is defined (`Rules += ...`) rather than where a shared-tile diagonal was created in the remapping function. Additionally, this re-implements the remapping function `transformSharedDiagonals` to optimize performance.
decrease radius of NWM intersection paths
Collaborator
Author
|
Ok, there are a few problems still. Apparently, there's an ID conflict between SAM × Owr4 T and SAM × Owr4m. |
piece ID switch from 27 to 1A
Technically, these are still correctly oriented, but once the switch to Avenue-based OWR-4 is implemented, they'd need to be revisited.
Collaborator
Author
|
Fixed. Ready for merge. I've also enabled the CI scripts on all branches and pull requests, so that we get more direct feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the OWR-4 metarules to an Avenue-based implementation. This includes improvements to the implementation of shared diagonals in RHW and NWM metarules.
Additionally, it splits off the NWM metarules from the RHW rule generator to facilitate independent developments (e.g. RHW×GLR fixes, viaduct or NWM extensions).
Therefore, I'd like to merge this PR now already in order to set a common base for further development and to avoid branch chaos. As the NWM metarules aren't "productive" yet, the should be no harm in merging this into
staging.