add advisor message to warn about NAM DLL incompatibility#518
Merged
Conversation
This uses the new Lua global variable `nam_dll_version`, added in NAMTeam/nam-dll#3
memo33
force-pushed
the
dll-advisor-message
branch
from
57b093f to
b3d556e
Compare
Collaborator
Author
|
This PR is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Lua file to display an advisor message if the NAM DLL is not installed or if a wrong version is installed.
This needs at least the upcoming DLL version 1.1.0 (NAMTeam/nam-dll#3). For older DLLs, the message will just always say "not installed" – older DLLs are incompatible or outdated either way.
The Lua file (
lua/adv_nam_dll.lua) is added to a new fileNetworkAddonMod_Advice.dat(up for discussion), which is compiled together with the INRULs. The nam_dll_version_expected variable in there needs to be kept in sync with the shipped NAM DLL file. The intention is to not distribute the Lua file with the DLL, but to distribute it with the rest of the NAM files in order to help ensure that players install the correct NAM DLL version for a particular NAM release.The DLL is incompatible with the macOS edition and the CD edition of the game. In those cases, installing the Lua file will always trigger the advisor popup message.
German translation included.