Skip to content

Commit 591c90e

Browse files
authored
Fix LoadRegionPlugin minDistance computation (#1480)
* Fix LoadRegionPlugin minDistance computation * Add calculateDistance in LoadRegionPlugin types
1 parent 8becbac commit 591c90e

3 files changed

Lines changed: 3 additions & 1 deletion

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ typings/
6262

6363
# IDEs and editors
6464
/.idea
65+
.vscode/settings.json
6566

6667
example/local-data
6768
example/dev-bundle

src/three/plugins/LoadRegionPlugin.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ declare class BaseRegion {
88
mask: boolean;
99
constructor( options?: { errorTarget?: number, mask?: boolean } );
1010
intersectsTile( boundingVolume: TileBoundingVolume, tile: Tile, tilesRenderer: TilesRenderer ): boolean
11+
calculateDistance( boundingVolume: TileBoundingVolume, tile: Tile, tilesRenderer: TilesRenderer ): number
1112
calculateError( tile: Tile, tilesRenderer: TilesRenderer ): number
1213

1314
}

src/three/plugins/LoadRegionPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export class LoadRegionPlugin {
7777
if ( intersects ) {
7878

7979
maxError = Math.max( region.calculateError( tile, tiles ), maxError );
80-
minDistance = Math.min( region.calculateDistance( boundingVolume, tile, tiles ) );
80+
minDistance = Math.min( region.calculateDistance( boundingVolume, tile, tiles ), minDistance );
8181

8282
}
8383

0 commit comments

Comments
 (0)