Move update-before, update-after to superclass (#1457)

Author: gkjohnson

src/core/renderer/tiles/TilesRendererBase.js

@@ -418,6 +418,7 @@ export class TilesRendererBase {
 
 	update() {
 
+		// load root
 		const { lruCache, usedSet, stats, root, downloadQueue, parseQueue, processNodeQueue, optimizedLoadStrategy } = this;
 		if ( this.rootLoadingState === UNLOADED ) {
 
@@ -471,6 +472,40 @@ export class TilesRendererBase {
 
 		}
 
+		// check if the plugins that can block the tile updates require it
+		let needsUpdate = null;
+		this.invokeAllPlugins( plugin => {
+
+			if ( plugin.doTilesNeedUpdate ) {
+
+				const res = plugin.doTilesNeedUpdate();
+				if ( needsUpdate === null ) {
+
+					needsUpdate = res;
+
+				} else {
+
+					needsUpdate = Boolean( needsUpdate || res );
+
+				}
+
+			}
+
+		} );
+
+		if ( needsUpdate === false ) {
+
+			this.dispatchEvent( { type: 'update-before' } );
+			this.dispatchEvent( { type: 'update-after' } );
+			return;
+
+		}
+
+		// follow through with the update
+		this.dispatchEvent( { type: 'update-before' } );
+
+		//
+
 		stats.inFrustum = 0;
 		stats.used = 0;
 		stats.active = 0;
@@ -485,6 +520,9 @@ export class TilesRendererBase {
 		downloadQueue.priorityCallback = priorityCallback;
 		parseQueue.priorityCallback = priorityCallback;
 
+		// prepare for traversal
+		this.prepareForTraversal();
+
 		// run traversal
 		if ( optimizedLoadStrategy ) {
 
@@ -527,6 +565,8 @@ export class TilesRendererBase {
 
 		}
 
+		this.dispatchEvent( { type: 'update-after' } );
+
 	}
 
 	resetFailedTiles() {
@@ -621,6 +661,8 @@ export class TilesRendererBase {
 
 	}
 
+	prepareForTraversal() {}
+
 	disposeTile( tile ) {
 
 		// TODO: are these necessary? Are we disposing tiles when they are currently visible?

src/three/renderer/tiles/TilesRenderer.js

@@ -391,39 +391,7 @@ export class TilesRenderer extends TilesRendererBase {
 
 	}
 
-	update() {
-
-		// check if the plugins that can block the tile updates require it
-		let needsUpdate = null;
-		this.invokeAllPlugins( plugin => {
-
-			if ( plugin.doTilesNeedUpdate ) {
-
-				const res = plugin.doTilesNeedUpdate();
-				if ( needsUpdate === null ) {
-
-					needsUpdate = res;
-
-				} else {
-
-					needsUpdate = Boolean( needsUpdate || res );
-
-				}
-
-			}
-
-		} );
-
-		if ( needsUpdate === false ) {
-
-			this.dispatchEvent( { type: 'update-before' } );
-			this.dispatchEvent( { type: 'update-after' } );
-			return;
-
-		}
-
-		// follow through with the update
-		this.dispatchEvent( { type: 'update-before' } );
+	prepareForTraversal() {
 
 		const group = this.group;
 		const cameras = this.cameras;
@@ -511,12 +479,14 @@ export class TilesRenderer extends TilesRendererBase {
 
 		}
 
-		super.update();
+	}
 
-		this.dispatchEvent( { type: 'update-after' } );
+	update() {
+
+		super.update();
 
 		// check for cameras _after_ base update so we can enable pre-loading the root tileset
-		if ( cameras.length === 0 && this.root ) {
+		if ( this.cameras.length === 0 && this.root ) {
 
 			let found = false;
 			this.invokeAllPlugins( plugin => found = found || Boolean( plugin !== this && plugin.calculateTileViewError ) );