Babylon: Import from subdirectory vs babylon/core. Fix container.dispose error (#1486)

* fix imports

* Revert accidentally dispose change

* side effect import

* side effects

* fix dipose issue

---------

Co-authored-by: Georgina Halpern <gehalper@microsoft.com>

Author: georginahalpern

example/babylonjs/googleMapsAerial.js

@@ -1,5 +1,11 @@
-import { Scene, Engine, GeospatialCamera, Vector3, Color4 } from '@babylonjs/core';
-import { GeospatialClippingBehavior } from '@babylonjs/core/Behaviors/Cameras';
+import { Scene } from '@babylonjs/core/scene';
+import { Engine } from '@babylonjs/core/Engines/engine';
+import { GeospatialCamera } from '@babylonjs/core/Cameras/geospatialCamera';
+import { Vector3 } from '@babylonjs/core/Maths/math.vector';
+import { Color4 } from '@babylonjs/core/Maths/math.color';
+import { GeospatialClippingBehavior } from '@babylonjs/core/Behaviors/Cameras/geospatialClippingBehavior';
+import '@babylonjs/core/Animations/animatable'; // Needed for flyTo animation
+import '@babylonjs/core/Collisions/collisionCoordinator'; // Needed to enable collisions on the camera
 import { TilesRenderer } from '3d-tiles-renderer/babylonjs';
 import { CesiumIonAuthPlugin } from '3d-tiles-renderer/core/plugins';
 import GUI from 'lil-gui';
@@ -53,7 +59,6 @@ camera.pitch = 1.167625429373872;
 camera.yaw = - 0.2513281792775774;
 
 camera.checkCollisions = true;
-scene.collisionsEnabled = true;
 
 // Fly to close view once tiles load
 let hasZoomedIn = false;

example/babylonjs/index.js

@@ -1,4 +1,8 @@
-import { Engine, Scene, ArcRotateCamera, Vector3, Color4 } from '@babylonjs/core';
+import { Engine } from '@babylonjs/core/Engines/engine';
+import { Scene } from '@babylonjs/core/scene';
+import { ArcRotateCamera } from '@babylonjs/core/Cameras/arcRotateCamera';
+import { Vector3 } from '@babylonjs/core/Maths/math.vector';
+import { Color4 } from '@babylonjs/core/Maths/math.color';
 import { TilesRenderer } from '3d-tiles-renderer/babylonjs';
 import GUI from 'lil-gui';
 

src/babylonjs/renderer/index.d.ts

@@ -1,5 +1,6 @@
 import { TilesRendererBase } from '3d-tiles-renderer/core';
-import { Scene, TransformNode } from '@babylonjs/core';
+import { Scene } from '@babylonjs/core/scene';
+import { TransformNode } from '@babylonjs/core/Meshes/transformNode';
 
 export class TilesRenderer extends TilesRendererBase {
 

src/babylonjs/renderer/loaders/B3DMLoader.js

@@ -1,4 +1,4 @@
-import { Matrix } from '@babylonjs/core';
+import { Matrix } from '@babylonjs/core/Maths/math.vector';
 import { B3DMLoaderBase } from '3d-tiles-renderer/core';
 import { GLTFLoader } from './GLTFLoader.js';
 

src/babylonjs/renderer/loaders/GLTFLoader.js

@@ -1,5 +1,6 @@
 import { LoaderBase } from '3d-tiles-renderer/core';
-import { Matrix, Quaternion, ImportMeshAsync } from '@babylonjs/core';
+import { Matrix, Quaternion } from '@babylonjs/core/Maths/math.vector';
+import { LoadAssetContainerAsync } from '@babylonjs/core/Loading/sceneLoader';
 import '@babylonjs/loaders/glTF/2.0';
 
 const _worldMatrix = /* @__PURE__ */ Matrix.Identity();
@@ -30,7 +31,7 @@ export class GLTFLoader extends LoaderBase {
 		// load the file
 		const pluginExtension = extension === 'gltf' ? '.gltf' : '.glb';
 		let metadata = null;
-		const container = await ImportMeshAsync(
+		const container = await LoadAssetContainerAsync(
 			new File( [ buffer ], uri ),
 			scene,
 			{
@@ -49,8 +50,10 @@ export class GLTFLoader extends LoaderBase {
 			}
 		);
 
+		container.addAllToScene();
+
 		// retrieve the primary scene
-		const root = container.meshes[ 0 ];
+		const root = container.rootNodes[ 0 ];
 
 		// ensure rotationQuaternion is initialized so we can decompose the matrix
 		root.rotationQuaternion = Quaternion.Identity();

src/babylonjs/renderer/math/OBB.js

@@ -1,4 +1,5 @@
-import { Vector3, Matrix, BoundingBox } from '@babylonjs/core';
+import { Vector3, Matrix } from '@babylonjs/core/Maths/math.vector';
+import { BoundingBox } from '@babylonjs/core/Culling/boundingBox';
 
 const _vec = /* @__PURE__ */ new Vector3();
 export class OBB {

src/babylonjs/renderer/math/TileBoundingVolume.js

@@ -1,4 +1,5 @@
-import { Vector3, Matrix, BoundingSphere } from '@babylonjs/core';
+import { Vector3, Matrix } from '@babylonjs/core/Maths/math.vector';
+import { BoundingSphere } from '@babylonjs/core/Culling/boundingSphere';
 import { OBB } from './OBB.js';
 
 const _vecX = /* @__PURE__ */ new Vector3();

src/babylonjs/renderer/tiles/TilesRenderer.js

@@ -1,5 +1,9 @@
 import { TilesRendererBase, LoaderUtils } from '3d-tiles-renderer/core';
-import { TransformNode, Matrix, Vector3, Frustum, Observable, Plane } from '@babylonjs/core';
+import { TransformNode } from '@babylonjs/core/Meshes/transformNode';
+import { Matrix, Vector3 } from '@babylonjs/core/Maths/math.vector';
+import { Frustum } from '@babylonjs/core/Maths/math.frustum';
+import { Observable } from '@babylonjs/core/Misc/observable';
+import { Plane } from '@babylonjs/core/Maths/math.plane';
 import { B3DMLoader } from '../loaders/B3DMLoader.js';
 import { GLTFLoader } from '../loaders/GLTFLoader.js';
 import { TileBoundingVolume } from '../math/TileBoundingVolume.js';