Tree nodes grow unbounded in orthographic view and easily run out of memory

[WilliamLiu-1997]

Description

When using the three globe XYZ image tile path, switching to an orthographic camera and browsing continuously causes memory usage to keep increasing. Switching back to a perspective camera does not make the memory drop in any noticeable way.
In orthographic view, the tree nodes number can easily exceed 1 million

Reproduction steps

1. Use the three globe XYZ image tile path
2. Switch to an orthographic camera
3. Pan, zoom, and browse continuously
4. Observe memory usage and tree node count

Code

registerPlugin(
new XYZTilesPlugin({
url: config.url,
center: true,
levels: config.levels ?? 20,
shape: 'ellipsoid',
} as any),
)

Live example

https://threejs-3d-tiles-renderer.vercel.app/

Screenshots & Tile Set

check the tree node number and memory useage

Library Version

newestVersion

Three.js Version

newestVersion

[gkjohnson]

Yes the image tiles grow until they reach the max depth of the tree and Orthographic cameras can be particularly problematic in these cases because every tile on the screen is displayed with the same pixel density.

The first step here is just deleting the generated children when a tile is disposed, which is what "QuantizedMeshPlugin" does here. This will truncate the tree anywhere that tiles have been unloaded in order to keep the tree more shallow.

tile.children.length = 0;

Is #1555 an AI-generated PR and description? It seems to make far too many changes for dealing with this.

[WilliamLiu-1997]

Yes the image tiles grow until they reach the max depth of the tree and Orthographic cameras can be particularly problematic in these cases because every tile on the screen is displayed with the same pixel density.

The first step here is just deleting the generated children when a tile is disposed, which is what "QuantizedMeshPlugin" does here. This will truncate the tree anywhere that tiles have been unloaded in order to keep the tree more shallow.

tile.children.length = 0;
Is #1555 an AI-generated PR and description? It seems to make far too many changes for dealing with this.

Thanks, yes, it seems AI gives me the wrong direction :(, I will close the PR and let you fix it? Thanks very much

[grahambates-code]

https://threejs-3d-tiles-renderer.vercel.app/

Is the source code for this Splat and map example available somewhere?

[WilliamLiu-1997]

https://threejs-3d-tiles-renderer.vercel.app/

Is the source code for this Splat and map example available somewhere?

I’m currently working on this Gaussian Splat plugin. At the moment, one of the packages(sparkjsdev) it depends on has an issue, and I’ve contacted the maintainers to help get it fixed. For now, I’ve temporarily patched their source code as a workaround. I plan to make the plugin public and probably open an PR here once the issue is resolved.

[gkjohnson]

let you fix it?

My time is already spread very thin so unfortunately I can't be expected to investigate, fix, and test every issue made in the project myself so I'd appreciate some effort to understand and address a problem from other contributors. I have pointed out a solution and another plugin that implements something similar both of which should be good places to start. I'm happy to answer any questions if you're running into issues.

And to be clear: in general I don't have an issue with AI - and I use it myself - but I have to expect that a contributor has been able to understand the code being contributed enough to validate the approach otherwise it's not fair to any reviewers time to review and give feedback. In my experience LLMs have proved to be very good at searching through code to find potential issues (though even these are often wrong) but have been terrible at making any kind of even moderately sized architectural decisions to solve a problem, as seen here. My recommendation is to use AI for what it's good at but ultimately the developer should be making decisions about how to fix a problem rather than the other way around.

[WilliamLiu-1997]

let you fix it?

My time is already spread very thin so unfortunately I can't be expected to investigate, fix, and test every issue made in the project myself so I'd appreciate some effort to understand and address a problem from other contributors. I have pointed out a solution and another plugin that implements something similar both of which should be good places to start. I'm happy to answer any questions if you're running into issues.

And to be clear: in general I don't have an issue with AI - and I use it myself - but I have to expect that a contributor has been able to understand the code being contributed enough to validate the approach otherwise it's not fair to any reviewers time to review and give feedback. In my experience LLMs have proved to be very good at searching through code to find potential issues (though even these are often wrong) but have been terrible at making any kind of even moderately sized architectural decisions to solve a problem, as seen here. My recommendation is to use AI for what it's good at but ultimately the developer should be making decisions about how to fix a problem rather than the other way around.

Thanks, I have reopen an PR

I have tested the last one made by AI and it works, so I thought it was right :(, I will be careful next time

[WilliamLiu-1997]

https://threejs-3d-tiles-renderer.vercel.app/

Is the source code for this Splat and map example available somewhere?

code is avaliable now, https://github.com/WilliamLiu-1997/3D-Tiles-RendererJS-3DGS-Plugin