Skip to content

Create an empty group if a loaded glb contains no scene #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkjohnson merged 3 commits into from
Mar 20, 2025
Merged

Create an empty group if a loaded glb contains no scene #1040

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d95f6
Create an empty group if a loaded glb contains no scene
WilliamLiu-1997 Mar 20, 2025
cc78f91
remove unnecessary changes
WilliamLiu-1997 Mar 20, 2025
68206bb
Update TilesRenderer.js
WilliamLiu-1997 Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/three/TilesRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
Euler,
LoadingManager,
EventDispatcher,
Group,
} from 'three';
import { raycastTraverse, raycastTraverseFirstHit } from './raycastTraverse.js';
import { readMagicBytes } from '../utilities/readMagicBytes.js';
Expand Down Expand Up @@ -660,6 +661,7 @@ export class TilesRenderer extends TilesRendererBase {
// any transformations applied to it can be assumed to be applied after load
// (such as applying RTC_CENTER) meaning they should happen _after_ the z-up
// rotation fix which is why "multiply" happens here.
result.scene = result.scene || new Group();
const { scene } = result;
scene.updateMatrix();
scene.matrix
Expand Down
Loading