clear children after dispose in imageFormatPlugin#1556
clear children after dispose in imageFormatPlugin#1556WilliamLiu-1997 wants to merge 2 commits intoNASA-AMMOS:masterfrom
Conversation
|
Thanks! Can you make sure you've tested with "TilesRenderer.optimizedLoadStrategy = true", as well, and test for regressions when scrolling around in the "mapTiles" and "wmtsTiles" demos, as well? They both use plugins that are based on ImageFormatsPlugin. |
optimizedLoadStrategy and mapTiles/wmtsTiles work, but I found an issue on this change: If we set I will investigate this and will let you know when I fix this issue |
|
I think it's worth reviewing what QuatizedMeshPlugin is doing more completely. In that plugin children are expanded in the "parseToMesh" function which means that children will only be available once the parent tile has been loaded and then, symmetrically, those children are deleted when the tile is unloaded in "disposeTile". We should follow this same pattern in "ImageFormat" plugin. |
Thanks, I have updated it according to what QuatizedMeshPlugin is doing. And I have tested it works fine with optimizedLoadStrategy and mapTiles/wmtsTiles |
relate to #1554