Skip to content

Refactor policy provider API and implementation#148

Merged
jeronstone merged 16 commits intomainfrom
109-pp-refactor
Apr 2, 2026
Merged

Refactor policy provider API and implementation#148
jeronstone merged 16 commits intomainfrom
109-pp-refactor

Conversation

@jeronstone
Copy link
Copy Markdown
Contributor

@jeronstone jeronstone commented Mar 27, 2026 •
edited
Loading

  • BPA threads now have one shared (mutex protected) policy provider
  • Updated backend to use m*lib array definition instead of static arrays
  • Updated API/workflow for initializing and adding policy rules and predicates to policy provider

Closes #109 #81

@jeronstone jeronstone added this to the BSL v1.1.0 milestone Mar 27, 2026
@jeronstone jeronstone self-assigned this Mar 27, 2026
@jeronstone jeronstone requested a review from a team as a code owner March 27, 2026 18:57
@jeronstone jeronstone added this to BSL Mar 27, 2026
@github-project-automation github-project-automation Bot moved this to Todo in BSL Mar 27, 2026
@jeronstone jeronstone linked an issue Mar 27, 2026 that may be closed by this pull request
BSLP_PolicyProvider_t Should have an Init / API #81
Closed
@jeronstone jeronstone changed the title DRAFT: Refactor policy provider API and backend Refactor policy provider API and backend Mar 27, 2026
jeronstone
jeronstone commented Mar 27, 2026
View reviewed changes
Comment thread src/policy_provider/SamplePolicyProvider.c Outdated
jeronstone
jeronstone commented Mar 27, 2026
View reviewed changes
Comment thread src/policy_provider/SamplePolicyProvider.h Outdated
@jeronstone jeronstone changed the title Refactor policy provider API and backend Refactor policy provider API and implementation Mar 27, 2026
BrianSipos
BrianSipos reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall structure is good, some questions raised and recommendations to properly avoid the sonar complaints.

Comment thread src/mock_bpa/policy_config.c Outdated
Comment thread src/policy_provider/SamplePolicyProvider.c
Comment thread src/policy_provider/SamplePolicyProvider.c Outdated
Comment thread src/policy_provider/SamplePolicyProvider.c Outdated
Comment thread src/policy_provider/SamplePolicyProvider.c Outdated
Comment thread src/policy_provider/SamplePolicyProvider.h Outdated
Comment thread src/policy_provider/SamplePolicyProvider.h Outdated
BrianSipos
BrianSipos approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in some docstring, but changes look good.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
80.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jeronstone jeronstone merged commit 92f5716 into main Apr 2, 2026
17 checks passed
@jeronstone jeronstone deleted the 109-pp-refactor branch April 2, 2026 21:07
@github-project-automation github-project-automation Bot moved this from Todo to Done in BSL Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrianSipos BrianSipos BrianSipos approved these changes

Assignees

@jeronstone jeronstone

Labels

None yet

Projects

BSL
Status: Done

Milestone

BSL v1.1.0

Development

Successfully merging this pull request may close these issues.

Refactor JSON to only parse file(s) once in MockBPA BSLP_PolicyProvider_t Should have an Init / API

2 participants

@jeronstone @BrianSipos