Comprehensive Tests of Public Interface#15
Merged
Merged
Conversation
This was
linked to
issues
Jul 28, 2025
BrianSipos
reviewed
Jul 28, 2025
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
Overall seems okay; for the portion modifying binary data there may be a more clear way to handle the modifications.
This was
unlinked from
issues
Jul 28, 2025
billvb
reviewed
Aug 4, 2025
billvb
reviewed
Aug 4, 2025
BrianSipos
reviewed
Aug 5, 2025
billvb
reviewed
Aug 7, 2025
jeronstone
commented
Aug 7, 2025
jeronstone
changed the title
jeronstone
changed the title
BrianSipos
approved these changes
Aug 14, 2025
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
You can address my comments any way you like (changes or tickets). The two CI jobs are currently failing because clang more strict requirement for end-of-file newline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds policy rules to test for sourcing, verification, and accepting of BIB and BCB blocks. Also tests for handling failure; policy actions drop block, drop bundle, do nothing.
The tests are roughly the following matrix:
role: [Source*, verify, accept],
on fail: [drop bundle, drop block, do nothing],
sec ctx: [BIB, BCB]
*on fail not tested with source
Passing 19/22.
2 issues pending issue 13.
1 issue in following case:
VERIFY bundle with OP(bib, payload), OP(bcb, payload). Attempts to match HMAC for bib despite BTSD being encrypted.
Also adds manual BSL_6, BSL_32