Skip to content

164 policy parse move#165

Merged
jeronstone merged 23 commits into
mainfrom
164-policy-parse-move
Apr 24, 2026
Merged

164 policy parse move#165
jeronstone merged 23 commits into
mainfrom
164-policy-parse-move

Conversation

@jeronstone

@jeronstone jeronstone commented Apr 23, 2026 •
edited by BrianSipos
Loading

Copy link
Copy Markdown
Contributor

Closes #164

@jeronstone jeronstone added this to the BSL v1.1.0 milestone Apr 23, 2026
@jeronstone jeronstone self-assigned this Apr 23, 2026
@jeronstone jeronstone requested a review from a team as a code owner April 23, 2026 18:47
@github-project-automation github-project-automation Bot moved this to Todo in BSL Apr 23, 2026
jeronstone
jeronstone commented Apr 23, 2026
View reviewed changes
Comment thread src/policy_provider/SamplePolicyConfigParser.c
@BrianSipos BrianSipos moved this from Todo to In Progress in BSL Apr 23, 2026
BrianSipos
BrianSipos reviewed Apr 23, 2026
View reviewed changes

@BrianSipos BrianSipos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of sonar warnings about const correctness which would be useful to correct now if possible.

Comment thread mock-bpa-test/test_bpa.py Outdated
Comment thread src/mock_bpa/key_registry.h
Comment thread src/policy_provider/SamplePolicyConfigParser.h
BrianSipos
BrianSipos reviewed Apr 23, 2026
View reviewed changes
Comment thread src/policy_provider/SamplePolicyConfigParser.c Outdated
@BrianSipos

BrianSipos commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

For the spell check, the words "JWKs" and "bsl" can be added to docs/api/dictionary.txt and I think these two are genuine misspellings:

bitstrings
seperated

BrianSipos
BrianSipos approved these changes Apr 24, 2026
View reviewed changes

@BrianSipos BrianSipos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good pending disposition of sonar complaints

BrianSipos
BrianSipos reviewed Apr 24, 2026
View reviewed changes
Comment thread src/policy_provider/SamplePolicyConfigParser.c Outdated
@sonarqubecloud

sonarqubecloud Bot commented Apr 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jeronstone jeronstone merged commit 99f1b76 into main Apr 24, 2026
17 checks passed
@jeronstone jeronstone deleted the 164-policy-parse-move branch April 24, 2026 16:01
@github-project-automation github-project-automation Bot moved this from In Progress to Done in BSL Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrianSipos BrianSipos BrianSipos approved these changes

Assignees

@jeronstone jeronstone

Labels

None yet

Projects

BSL
Status: Done

Milestone

BSL v1.1.0

Development

Successfully merging this pull request may close these issues.

Move JSON policy parsing out of Mock BPA to Sample PP

2 participants

@jeronstone @BrianSipos