Skip to content

Security Actions & Security Operation Handling#48

Merged
jeronstone merged 23 commits into
mainfrom
policy_provider_rework
Aug 13, 2025
Merged

Security Actions & Security Operation Handling#48
jeronstone merged 23 commits into
mainfrom
policy_provider_rework

Conversation

@jeronstone
Copy link
Copy Markdown
Contributor

@jeronstone jeronstone commented Aug 12, 2025

Notable Changes

Creates singular Action structure, containing ordered list of SecOps. ActionSets now contain (not-necessarily ordered) list of Actions.

  • New SecOps added to an Action have their parameters checked to determine order - for example, if a new SecOp(tgt=payload, ctx=BIB, role=ACCEPT), it should be added after SecOp(tgt=payload, ctx=BCB, role=ACCEPT).
  • ActionSets now use an M*lib struct to hold actions to remove hard limit on capacity

Adds conclusions to SecOps

Copied from other open PR for clarity

@jeronstone jeronstone requested a review from a team as a code owner August 12, 2025 15:50
@jeronstone jeronstone self-assigned this Aug 12, 2025
@jeronstone jeronstone added the enhancement New feature or request label Aug 12, 2025
@jeronstone jeronstone added this to BSL Aug 12, 2025
@github-project-automation github-project-automation Bot moved this to Todo in BSL Aug 12, 2025
BrianSipos
BrianSipos reviewed Aug 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specific comments about OPLIST validity and extension. I can touch these up if it helps.

Comment thread src/backend/SecOperation.h
Comment thread src/backend/SecurityAction.h Outdated
Comment thread src/backend/SecurityActionSet.h Outdated
This was linked to issues Aug 12, 2025
Implement & Handle SecOp conclusion codes in policy provider #42
Closed
ActionSets should contain Actions #44
Closed
@BrianSipos BrianSipos moved this from Todo to In Progress in BSL Aug 12, 2025
@BrianSipos BrianSipos added this to the BSL v1.0.0 milestone Aug 12, 2025
@BrianSipos BrianSipos mentioned this pull request Aug 12, 2025
Open
BrianSipos
BrianSipos reviewed Aug 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BrianSipos BrianSipos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about what was mostly already there. If there are other "magic" bare numbers in the source, please write up bug tickets to replace them with at least preprocessor macro names to allow some consistency.

Comment thread src/policy_provider/SamplePolicyProvider.c
Comment thread src/policy_provider/SamplePolicyProvider.c
Comment thread src/policy_provider/SamplePolicyProvider.c Outdated
Comment thread src/policy_provider/SamplePolicyProvider.c Outdated
@jeronstone jeronstone merged commit d926f2a into main Aug 13, 2025
10 checks passed
@jeronstone jeronstone deleted the policy_provider_rework branch August 13, 2025 15:38
@github-project-automation github-project-automation Bot moved this from In Progress to Done in BSL Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrianSipos BrianSipos BrianSipos approved these changes

Assignees

@jeronstone jeronstone

Labels

enhancement New feature or request

Projects

BSL
Status: Done

Milestone

BSL v1.0.0

Development

Successfully merging this pull request may close these issues.

ActionSets should contain Actions Implement & Handle SecOp conclusion codes in policy provider

2 participants

@jeronstone @BrianSipos