Multiple Policy Provider Support#80
Merged
Merged
Conversation
jeronstone
added
the
CRIT-1
BrianSipos
reviewed
Aug 18, 2025
BrianSipos
left a comment
BrianSipos
left a comment
Collaborator
There was a problem hiding this comment.
Updated behavior looks good. Only comments are about avoiding copies and const correctness.
BrianSipos
reviewed
Aug 18, 2025
BrianSipos
reviewed
Aug 18, 2025
BrianSipos
reviewed
Aug 18, 2025
BrianSipos
reviewed
Aug 18, 2025
BrianSipos
reviewed
Aug 18, 2025
BrianSipos
reviewed
Aug 20, 2025
BrianSipos
left a comment
BrianSipos
left a comment
Collaborator
There was a problem hiding this comment.
This looks good except for the finalize. It could be good to have a unit test function that registers two PPs, creates dummy actions from each, and verifies that the finalize gives the correct action to the correct PP.
…into stone-policy-dict
BrianSipos
approved these changes
Aug 22, 2025
BrianSipos
left a comment
BrianSipos
left a comment
Collaborator
There was a problem hiding this comment.
Source looks good, one comment about docs to check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds registry for policy providers. Right now, PP IDs are just
uint64s, can change to a string / bytestring / some other identifier.Closes #28