Fixing library configs to avoid duplicate building of compilation units#9
Merged
Conversation
jeronstone
force-pushed
the
fix-library-config
branch
from
20516ba to
3be582a
Compare
jeronstone
force-pushed
the
fix-library-config
branch
from
42aa0da to
0ccebd8
Compare
jeronstone
force-pushed
the
fix-library-config
branch
from
0ccebd8 to
b2554b2
Compare
BrianSipos
commented
Jul 24, 2025
BrianSipos
left a comment
BrianSipos
left a comment
Collaborator
Author
There was a problem hiding this comment.
This all looks good to me
jeronstone
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously each library source was marked as PUBLIC so was being re-built for every using library / executable.