fix: prevent infinite redirect loop when ROOT_PATH is set#950
Merged
tariqksoliman merged 6 commits intoNASA-AMMOS:developmentfrom Apr 23, 2026
Merged
fix: prevent infinite redirect loop when ROOT_PATH is set#950tariqksoliman merged 6 commits intoNASA-AMMOS:developmentfrom
tariqksoliman merged 6 commits intoNASA-AMMOS:developmentfrom
Conversation
Co-Authored-By: tariq.k.soliman <tariqksoliman@gmail.com>
…me-v2 fix: add curl to runtime stage for healthcheck support
When ROOT_PATH is set (e.g. /lunarsouthpole), Express non-strict route matching causes app.get(ROOT_PATH) to match both /lunarsouthpole and /lunarsouthpole/, creating an infinite 301 redirect loop. Add a guard so the redirect only fires when the request path does NOT already end with '/'. When it does, call next() to pass control to the main application route handler. Co-Authored-By: tariq.k.soliman <tariqksoliman@gmail.com>
…redirect-loop fix: prevent infinite redirect loop when ROOT_PATH is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Devin
JPL-Devin#43