Skip to content

IDS-10384: Encode CRLF in log output to prevent log injection (S5145) #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesfwood merged 1 commit into from
Jun 16, 2026
Merged

IDS-10384: Encode CRLF in log output to prevent log injection (S5145) #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cws-installer/src/main/resources/log4j2.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ status = warn
appender.console.type = Console
appender.console.name = STDOUT
appender.console.layout.type = PatternLayout
appender.console.layout.pattern = INSTALLER: %d{ISO8601}{UTC} %-5p [%20.20t] %30.30c(%4.4L) - %m%n
appender.console.layout.pattern = INSTALLER: %d{ISO8601}{UTC} %-5p [%20.20t] %30.30c(%4.4L) - %encode{%m}{CRLF}%n

# configure loggers
# Spring Framework
Expand Down
6 changes: 3 additions & 3 deletions install/tomcat_lib/log4j2-tomcat.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ appender.rolling.name = RollingFile
appender.rolling.fileName = ${sys:catalina.base}/logs/cws.log
appender.rolling.filePattern = ${sys:catalina.base}/logs/cws.%d{yyyy-MM-dd}.log
appender.rolling.layout.type = PatternLayout
appender.rolling.layout.pattern = %d{ISO8601}{UTC} %-5p [%20.20t] %30.30c(%4.4L) - %m%n
appender.rolling.layout.pattern = %d{ISO8601}{UTC} %-5p [%20.20t] %30.30c(%4.4L) - %encode{%m}{CRLF}%n
appender.rolling.policies.type = Policies
appender.rolling.policies.time.type = TimeBasedTriggeringPolicy
appender.rolling.policies.time.interval = 1
Expand All @@ -30,7 +30,7 @@ appender.artemis.name = ArtemisFile
appender.artemis.fileName = ${sys:catalina.base}/logs/artemis.log
appender.artemis.filePattern = ${sys:catalina.base}/logs/artemis.%d{yyyy-MM-dd}.log
appender.artemis.layout.type = PatternLayout
appender.artemis.layout.pattern = %d{ISO8601}{UTC} %-5p [%20.20t] %30.30c(%4.4L) - %m%n
appender.artemis.layout.pattern = %d{ISO8601}{UTC} %-5p [%20.20t] %30.30c(%4.4L) - %encode{%m}{CRLF}%n
appender.artemis.policies.type = Policies
appender.artemis.policies.time.type = TimeBasedTriggeringPolicy
appender.artemis.policies.time.interval = 1
Expand All @@ -49,7 +49,7 @@ appender.rolling.strategy.fileIndex = nomax
appender.CONSOLE.type = Console
appender.CONSOLE.name = STDOUT
appender.CONSOLE.layout.type = PatternLayout
appender.CONSOLE.layout.pattern = %d{ISO8601}{UTC} %-5p [%20.20t] %30.30c(%4.4L) - %m%n
appender.CONSOLE.layout.pattern = %d{ISO8601}{UTC} %-5p [%20.20t] %30.30c(%4.4L) - %encode{%m}{CRLF}%n

## Configure which loggers log to which appenders

Expand Down