Updating Historical Export Filenames to use the view name instead of the first child endpoint name (#321)

Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com>

Author: jvigliotta

src/exportDataAction/ExportDataAction.js

@@ -18,7 +18,6 @@ class ExportDataAction {
     this.group = 'view';
     this.priority = 1;
     this.validTypes = validTypes;
-    this.sessionService = SessionService();
 
     this.openmct = openmct;
   }
@@ -63,12 +62,16 @@ class ExportDataAction {
     );
 
     if (filteredComposition.length > 0) {
-      await this.runExportTask(filteredComposition);
+      await this.runExportTask(filteredComposition, domainObject.name);
     } else {
       this.openmct.notifications.info('No historical data to export');
     }
   }
 
+  getHistoricalSessionFilter() {
+    return SessionService().getHistoricalSessionFilter();
+  }
+
   historicalFilterString(sessionFilter) {
     let filterString = formatNumberSequence(sessionFilter.numbers);
 
@@ -78,9 +81,18 @@ class ExportDataAction {
     return `${sessionFilter.host}_${filterString}`;
   }
 
-  runExportTask(domainObjects) {
-    let filename = domainObjects[0].name;
-    const sessionFilter = this.sessionService.getHistoricalSessionFilter();
+  /**
+   * Runs the export task for the given domain objects with an optional name.
+   * If no name is provided, uses the name of the first domain object.
+   * Appends session filter information to the filename if a session filter exists.
+   *
+   * @param {Array<Object>} domainObjects - Array of domain objects to export
+   * @param {string} [name] - Optional name for the export file. If not provided, uses the name of the first domain object
+   * @returns {Promise} A promise that resolves when the export task is complete
+   */
+  runExportTask(domainObjects, name) {
+    let filename = name ?? domainObjects[0].name;
+    const sessionFilter = this.getHistoricalSessionFilter();
 
     if (sessionFilter) {
       filename = `${filename} - ${this.historicalFilterString(sessionFilter)}`;

src/exportDataAction/ExportDataActionSpec.js

@@ -77,6 +77,12 @@ define(['./ExportDataAction'], (ExportDataActionModule) => {
       mockOpenmct.notifications.progress.and.returnValue(mockNotification);
 
       exportDataAction = new ExportDataAction(mockOpenmct, ['validType']);
+      spyOn(exportDataAction, 'getHistoricalSessionFilter').and.callFake(() => {
+        return {
+          host: 'test-host',
+          numbers: [1, 2, 3, 4, 5]
+        };
+      });
     });
 
     it('applies to objects with a valid type', () => {
@@ -114,7 +120,6 @@ define(['./ExportDataAction'], (ExportDataActionModule) => {
               done();
             }
           };
-
           spyOn(exportDataAction, 'runExportTask').and.callThrough();
           spyOn(exportDataAction, 'exportCompositionData').and.callThrough();
           mockTarget = singular ? mockTelemetryObject : mockTelemetryObjectWithComposition;
@@ -160,10 +165,16 @@ define(['./ExportDataAction'], (ExportDataActionModule) => {
             it('triggers a CSV export for one object', () => {
               expect(exportDataAction.runExportTask).toHaveBeenCalled();
             });
+            it('checks for historical session filter', () => {
+              expect(exportDataAction.getHistoricalSessionFilter).toHaveBeenCalled();
+            });
           } else {
             it('triggers a CSV export for each object', () => {
               expect(exportDataAction.exportCompositionData).toHaveBeenCalled();
             });
+            it('checks for historical session filter', () => {
+              expect(exportDataAction.getHistoricalSessionFilter).toHaveBeenCalled();
+            });
           }
         });