Updated EVR Module and Level Stream filters to always use uppercase for internal consistency

Author: Peter Di Pasquale

src/realtime/MCWSEVRLevelStreamProvider.js

@@ -31,7 +31,7 @@ class MCWSEVRLevelStreamProvider extends MCWSStreamProvider {
      * @returns {String} The key
      */
     getKey(domainObject) {
-        return domainObject.telemetry.level;
+        return domainObject.telemetry.level.toUpperCase();
     }
 }
 

src/realtime/MCWSEVRStreamProvider.js

@@ -32,18 +32,27 @@ class MCWSEVRStreamProvider extends MCWSStreamProvider {
      */
     getKey(domainObject) {
         // Can subscribe only by EVR module even if subscribing by EVR
+        // This is the default cause for EVRs that contain a module.
         let module = domainObject.telemetry
             && domainObject.telemetry.definition
             && domainObject.telemetry.definition.module
-            && domainObject.telemetry.definition.module.toLowerCase();
+            && domainObject.telemetry.definition.module.toUpperCase();
+
+        // This is the top-level vista.evrModule object, which contains 
+        // A module definition but not in the definition object.  
+        // This must be captured before an attempt at legacy EVRs is made
+        // in case the module has underscores in it. 
+        if (!module || module.length <= 0) {
+            module = domainObject.telemetry
+                && domainObject.telemetry.module
+                && domainObject.telemetry.module.toUpperCase();
+        }
 
         // legacy inference of module by evr_name
-        // if this fallback is used will break on module names containing underscores
+        // This should *never* occur with modern telemetry dictionaries. 
         if (!module || module.length <= 0) {
             console.warn('Legacy domain objects should not be used anymore!');
-            module = domainObject.telemetry.evr_name ?
-                domainObject.telemetry.evr_name.split("_")[0].toLowerCase() :
-                domainObject.telemetry.module.toLowerCase();
+            module = domainObject.telemetry.evr_name.split("_")[0].toUpperCase()
         }
 
         return module;

src/realtime/MCWSStreamWorkerScript.js

@@ -194,8 +194,7 @@
         const data = JSON.parse(message.data);
 
         data.forEach((datum) => {
-          const key = datum[property];
-
+          const key = datum[property].toUpperCase();
           if (subscribers[key] > 0) {
             self.postMessage({
               url: url,