Sonarcloud updates#273
Merged
Merged
Conversation
davetsay
reviewed
Feb 6, 2025
| push: | ||
| branches: [ "main", "release/*" ] | ||
| pull_request: | ||
| branches: [ "main", "release/*" ] |
davetsay
reviewed
Feb 6, 2025
|
|
||
| on: | ||
| push: | ||
| branches: [ "main", "release/*" ] |
davetsay
reviewed
Feb 6, 2025
Collaborator
davetsay
left a comment
davetsay
left a comment
There was a problem hiding this comment.
This looks good to me. I just have one question. I see some scrub stuff included, and some scrub stuff commented out. Are we able to now just remove scrub entirely? Or, is there an interim phase while all the projects get onto SonarCloud?
Collaborator
|
@lylebarner , also, a sonarcloud action is failing |
|
davetsay
approved these changes
Aug 7, 2025
Collaborator
davetsay
left a comment
davetsay
left a comment
There was a problem hiding this comment.
SONAR_TOKEN has been added to repository. Looks Good!
auto-merge was automatically disabled
August 7, 2025 18:34
Pull Request is not mergeable
|
davetsay
added a commit
that referenced
this pull request
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request incorporates changes required to allow openmct-mcws to allow for security scanning to be performed using SonarCloud
Remaining actions required to enable analysis