Skip to content

354 fix redos vulnerable regex patterns #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heathdutton wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

354 fix redos vulnerable regex patterns #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea0a36
354 fix redos vulnerable regex patterns
heathdutton Feb 12, 2026
d976f41
Merge branch 'main' into 354-fix-redos-vulnerable-regex
jvigliotta Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/persistence/BaseMCWSPersistenceProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import mcws from '../services/mcws/mcws.js';
import { createModelFromNamespaceDefinitionWithPersisted, interpolateUsername } from './utils.js';

const USERNAME_FROM_PATH_REGEX = new RegExp('.*/(.*?)$');
const USERNAME_FROM_PATH_REGEX = new RegExp('([^/]*)$');

/**
* An object defining a MCWS namespace. Provides a unique identifier for a
Expand Down
2 changes: 1 addition & 1 deletion src/services/dataset/Dataset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class Dataset {
}

omitsDictionaryVersion(url) {
return /\/.*Dictionary\/?$/.test(url);
return /\/[^/]*Dictionary\/?$/.test(url);
}

/**
Expand Down